! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Display brightness label visible without dropdown
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfce4-power-manager
Component:
General

Comments

Description Pasi Lallinaho editbugs 2018-09-01 20:57:49 CEST 
Created attachment 7926 
Dialog with the label but no dropdown

The "Handle display brightness keys" label is shown, but there is no dropdown box to modify the option. This is a desktop machine, so the lack of the dropdown box is expected as there are no display brightness keys.
Comment 1 Andre Miranda editbugs 2018-09-23 21:38:32 CEST 
Created attachment 7998 
fix patch

Hopefully this patch fixes the problem, I can't test (laptop here).
Comment 2 Andre Miranda editbugs 2018-09-23 21:42:09 CEST 
Created attachment 7999 
small improvement

I noticed that the spin under System -> Critical power -> Critical battery power level is too short. This patch makes it a bit wider.
Yes, I'm too lazy to file another bug just for this trivial improvement.
Comment 3 Andre Miranda editbugs 2018-09-27 03:13:11 CEST 
*** Bug 14726 has been marked as a duplicate of this bug. ***
Comment 4 Theo Linkspfeifer editbugs 2019-07-29 19:31:52 CEST 
*** Bug 15759 has been marked as a duplicate of this bug. ***
Comment 5 Git Bot editbugs 2019-08-06 17:09:55 CEST 
Simon Steinbeiss referenced this bugreport in commit f914df0838c815515a054093d726c69fff274c13

Correctly hide brightness label (Bug #14649)

https://git.xfce.org/xfce/xfce4-power-manager/commit?id=f914df0838c815515a054093d726c69fff274c13
Comment 6 Simon Steinbeiss editbugs 2019-08-06 17:15:23 CEST 
@Andre: Thanks for the first patch. The second one did not apply - I adjusted and pushed it though.

Bug #14649

Reported by:
Pasi Lallinaho
Reported on: 2018-09-01
Last modified on: 2019-08-06
Duplicates (2):
  • 14726 Handle display brightness keys checkbox missing
  • 15759 No checkbox in xfce4- power-manager

People

Assignee:
Ali Abdallah
CC List:
6 users

Version

Version:
1.6.1
Target Milestone:
---

Attachments

Dialog with the label but no dropdown (43.46 KB, image/png)
2018-09-01 20:57 CEST , Pasi Lallinaho 		no flags
fix patch (1.25 KB, patch)
2018-09-23 21:38 CEST , Andre Miranda 		no flags
small improvement (871 bytes, patch)
2018-09-23 21:42 CEST , Andre Miranda 		no flags

Additional information