! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
"Confirm close" dialog's "Close tab" button closes the window instead
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description mirh 2018-08-31 19:06:04 CEST
Also on git.
Comment 1 Igor editbugs 2018-08-31 19:24:27 CEST
You mean, closing a tab when it's the only tab closes the window? That's the intended behavior.
Comment 2 mirh 2018-09-01 16:33:10 CEST
I don't think you are even prompted the "are you sure you want to close" window with a single tab. 
I meant with more than one tab.
Comment 3 Igor editbugs 2018-09-03 21:49:32 CEST
(In reply to mirh from comment #2)
> I meant with more than one tab.
I cannot reproduce the issue here.

What is the scenario to reproduce it? What distro are you using? What is your vte version? Do system logs (e..g, `journalctl` for systemd systems) show any useful info?
Comment 4 mirh 2018-09-05 01:20:28 CEST
The scenario is really that. You open two tabs, you press the X on the upper right, then "close tab".. and everything closes. 
I'm using latest manjaro, vte3 is 0.52.2 (vte is 0.28.2), journalctl shows nothing.
Comment 5 Igor editbugs 2018-09-05 14:42:56 CEST
I can see what you mean now, thanks for the report!
Comment 6 Git Bot editbugs 2018-09-05 21:38:28 CEST
Igor referenced this bugreport in commit 49de8821b08c490297a518f9a4472f85de5f3c25

Fix the "Close tab" button

https://git.xfce.org/apps/xfce4-terminal/commit?id=49de8821b08c490297a518f9a4472f85de5f3c25
Comment 7 Igor editbugs 2018-09-05 21:38:56 CEST
Fixed by the commit above.
Comment 8 mirh 2018-09-06 00:33:50 CEST
Yep, thanks.

Bug #14645

Reported by:
mirh
Reported on: 2018-08-31
Last modified on: 2018-09-06

People

CC List:
0 users

Version

Version:
0.8.7.4

Attachments

Additional information