! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Build fails with ENABLE_DEVELOPER_MODE=ON on Arch
Status:
RESOLVED: INVALID
Product:
Xfce4-whiskermenu-plugin
Component:
General

Comments

Description Peter Feichtinger 2018-08-29 05:56:33 CEST
The build fails because of several reasons when ENABLE_DEVELOPER_MODE=ON is used with the git master on a recently update Arch Linux machine:
 * There's a huge number of -Wparentheses warnings treated as errors coming from GTK include files (declarations like `void (*__gtk_reserved1);`)
 * When I disable this specific warning, then it fails because GtkImageMenuItem used in command.cpp is deprecated and GTK_DISABLE_DEPRECATED prevents it from even being included.

Is Whisker Menu supposed to build with ENABLE_DEVELOPER_MODE turned on?
If it's not then I suggest removing that option altogether.
Comment 1 Graeme Gott editbugs 2018-08-29 11:57:40 CEST
The huge number of warnings about parentheses is actually a GTK bug that is already fixed and should be in the next 3.22 release (https://gitlab.gnome.org/GNOME/gtk/issues/1059)

This option is useless for end users, and is there to help me find extra errors. I know that it doesn't build with it at the moment, but it is still useful for me. Which is why it is called *developer mode*.
Comment 2 Peter Feichtinger 2018-08-29 16:12:02 CEST
So you do use it, just not right now, got it.
I'm asking because I'd like to contribute, should I generally just do a pull request on GitHub and discuss there or open an issue first?
Comment 3 Graeme Gott editbugs 2018-08-29 18:34:00 CEST
(In reply to Peter Feichtinger from comment #2)
> So you do use it, just not right now, got it.
> I'm asking because I'd like to contribute, should I generally just do a pull
> request on GitHub and discuss there or open an issue first?

I would prefer a Bugzilla issue opened first, with the mention that you would like to implement it. That way we can discuss the feature before you get started, just to make sure it fits with the rest of Whisker Menu.

Bug #14637

Reported by:
Peter Feichtinger
Reported on: 2018-08-29
Last modified on: 2018-08-29

People

Assignee:
Graeme Gott
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information