! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
wi_linux.c:159]: (style) Suspicious condition
Status:
RESOLVED: FIXED
Product:
Xfce4-wavelan-plugin
Component:
General

Comments

Description David Binderman 2018-08-26 14:34:57 CEST
wi_linux.c:159]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

  if ((result = ioctl(device->socket, SIOCGIWESSID, &wreq) < 0)) {

Maybe better code

  if ((result = ioctl(device->socket, SIOCGIWESSID, &wreq)) < 0) {

wi_linux.c:170]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Duplicate.
Comment 1 Git Bot editbugs 2018-09-01 09:34:03 CEST
Landry Breuil referenced this bugreport in commit 5f4c12a585fab6e1b5ed246ccd29699768f64db2

fix "Suspicious condition (assignment + comparison)" warnings by moving parenthesis (bug #14632)

https://git.xfce.org/panel-plugins/xfce4-wavelan-plugin/commit?id=5f4c12a585fab6e1b5ed246ccd29699768f64db2
Comment 2 Landry Breuil editbugs 2018-09-01 09:34:58 CEST
Thanks !

Bug #14632

Reported by:
David Binderman
Reported on: 2018-08-26
Last modified on: 2018-09-01

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information