! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Some context menu entries are not properly aligned
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfdesktop
Component:
General

Comments

Description Theo Linkspfeifer editbugs 2018-08-24 17:21:51 CEST 
Created attachment 7905 
screenshot

Gtk menu items without an icon and entries in the "Open with" submenu are not properly aligned.
Comment 1 Theo Linkspfeifer editbugs 2018-08-24 17:23:06 CEST 
Created attachment 7906 
proposed patch
Comment 2 Git Bot editbugs 2018-08-26 04:14:24 CEST 
Theo Linkspfeifer referenced this bugreport in commit 7c451f864b3b39ab3cc220572ccb292e5e7dae42

Add padding to some context menu icons (Bug #14628)

https://git.xfce.org/xfce/xfdesktop/commit?id=7c451f864b3b39ab3cc220572ccb292e5e7dae42
Comment 3 Andre Miranda editbugs 2018-08-26 04:15:52 CEST 
It seems a hack, but gtk3 doesn't give us much choice: use deprecated gtk_image_menu_item, menu items without icons (gnome's vision, not ours), menu items with image + label in box result in ugly padding or no padding at all, or this workaround.

So I pushed to master, if it causes any trouble we can always revert before 4.14.
Thanks!
Comment 4 Theo Linkspfeifer editbugs 2019-07-09 15:05:43 CEST 
Created attachment 8742 
same fix for the Window Actions context menu entry
Comment 5 Git Bot editbugs 2019-07-11 04:25:22 CEST 
Theo Linkspfeifer referenced this bugreport in commit 7328581b30410d7e29e68ee5d356d9627feaa544

Add padding to Window Actions menu entry (Bug #14628)

https://git.xfce.org/xfce/xfdesktop/commit?id=7328581b30410d7e29e68ee5d356d9627feaa544
Comment 6 Theo Linkspfeifer editbugs 2019-10-23 15:54:30 CEST 
I just saw that custom actions without icon are affected also. No patch though.
Comment 7 Andre Miranda editbugs 2019-11-03 18:43:18 CET 
Created attachment 9182 
custom action without icon

(In reply to Theo Linkspfeifer from comment #6)
> I just saw that custom actions without icon are affected also. No patch
> though.

Looks good to me.
Comment 8 Git Bot editbugs 2019-11-04 00:27:34 CET 
Andre Miranda referenced this bugreport in commit 565dbc08235cfdf99f3c4c3b00f62352a41159b4

Add padding to custom actions without icon (Bug #14628)

https://git.xfce.org/xfce/xfdesktop/commit?id=565dbc08235cfdf99f3c4c3b00f62352a41159b4
Comment 9 Git Bot editbugs 2019-11-04 00:28:04 CET 
Andre Miranda referenced this bugreport in commit 2175e5822ed40161cd2e647578a3a6c6072d8993

Add padding to custom actions without icon (Bug #14628)

https://git.xfce.org/xfce/xfdesktop/commit?id=2175e5822ed40161cd2e647578a3a6c6072d8993

Bug #14628

Reported by:
Theo Linkspfeifer
Reported on: 2018-08-24
Last modified on: 2019-11-04

People

Assignee:
Eric Koegel
CC List:
1 user

Version

Version:
4.13.2
Target Milestone:
Xfce 4.14

Attachments

screenshot (45.81 KB, image/png)
2018-08-24 17:21 CEST , Theo Linkspfeifer 		no flags
proposed patch (3.04 KB, patch)
2018-08-24 17:23 CEST , Theo Linkspfeifer 		no flags
same fix for the Window Actions context menu entry (1.31 KB, patch)
2019-07-09 15:05 CEST , Theo Linkspfeifer 		no flags
custom action without icon (10.80 KB, image/png)
2019-11-03 18:43 CET , Andre Miranda 		no flags

Additional information