! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[xfce4-appfinder] Convert Appdata file to Appstream
Status:
RESOLVED: FIXED
Product:
Xfce4-appfinder
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2018-08-22 13:04:14 CEST
Similar bug to #14037 #14094 and #14620, the specification for AppData has evolved into AppStream. The current file should be updated and installed in the correct location (/usr/share/metainfo/).
Comment 1 Andre Miranda editbugs 2018-08-23 02:45:43 CEST
Created attachment 7900 
patch

Please review the attached patch before I push to master.
Comment 2 Yves-Alexis Perez editbugs 2018-08-23 09:19:30 CEST
Hi, is that pushed to a branch somewhere I can fetch?
Comment 3 Andre Miranda editbugs 2018-08-23 14:09:18 CEST
Nope, you're supposed to apply it against master and let me know if I forgot anything, expect the screenshot size warning than I ignored on purpose  =)
Comment 4 Yves-Alexis Perez editbugs 2018-08-23 14:40:57 CEST
It looks ok at first sight. validate-strict still shows other warnings:

data/org.xfce.xfce4-appfinder.appdata.xml.in: FAILED:
• tag-invalid           : <updatecontact> should be <update_contact>
• attribute-invalid     : <screenshot> width too small [https://docs.xfce.org/_media/xfce/xfce4-appfinder/xfce4-appfinder-expanded.png] minimum is 624px
• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://docs.xfce.org/_media/xfce/xfce4-appfinder/xfce4-appfinder-expanded.png]
• translations-required  : <name> has no translations
• translations-required  : <summary> has no translations

But that could be fixed later on (especially translations).
Comment 5 Git Bot editbugs 2018-08-24 03:19:16 CEST
Andre Miranda referenced this bugreport in commit bb312f457b1bd07d215aae9ff5fa42d407ccc7bd

Convert AppData file to AppStream (Bug #14624)

https://git.xfce.org/xfce/xfce4-appfinder/commit?id=bb312f457b1bd07d215aae9ff5fa42d407ccc7bd

Bug #14624

Reported by:
Yves-Alexis Perez
Reported on: 2018-08-22
Last modified on: 2018-08-24

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
Unspecified

Attachments

patch (3.22 KB, patch)
2018-08-23 02:45 CEST , Andre Miranda
no flags

Additional information