! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch] Thunar UAC forgets keyboard shortcut
Status:
RESOLVED: FIXED

Comments

Description Anna Arad 2018-08-19 17:55:23 CEST
Created attachment 7892 
Patch to fix the issue

When editing a UAC, if the keyboard shortcut button isn't pressed, the previous keyboard shortcut is forgotten when OK is pressed.

Steps to recreate:
Edit a UAC with a previously set keyboard shortcut.
Just press OK.
Edit the UAC again, and the keyboard shortcut is missing.
Comment 1 Anna Arad 2018-08-19 18:27:34 CEST
Created attachment 7893 
Fixed patch
Comment 2 Andre Miranda editbugs 2018-08-21 04:00:47 CEST
Thanks for the patch, I can't believe this bug was overlooked , I even remember experiencing this.
I would push it right away, but in order to keep authorship, please make a commit and generate the patch with git format-patch (unless you don't care, just say I'll push it in my name).
Comment 3 Anna Arad 2018-08-21 10:51:04 CEST
Created attachment 7894 
Patch

Here you go.

Thanks :)
Comment 4 Git Bot editbugs 2018-08-22 03:46:46 CEST
Anna Arad referenced this bugreport in commit f1f52e5f6db4507a3754a938b1fae189d96a63c3

Fix UAC forgets keyboard shortcut (Bug #14617)

https://git.xfce.org/xfce/thunar/commit?id=f1f52e5f6db4507a3754a938b1fae189d96a63c3
Comment 5 Git Bot editbugs 2018-08-22 03:47:28 CEST
Anna Arad referenced this bugreport in commit e8c128ac47951497956a77ef015dd6f927f24734

Fix UAC forgets keyboard shortcut (Bug #14617)

https://git.xfce.org/xfce/thunar/commit?id=e8c128ac47951497956a77ef015dd6f927f24734
Comment 6 Andre Miranda editbugs 2018-08-22 03:48:24 CEST
No, thank *you* :)

Bug #14617

Reported by:
Anna Arad
Reported on: 2018-08-19
Last modified on: 2018-08-22

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Attachments

Patch to fix the issue (783 bytes, patch)
2018-08-19 17:55 CEST , Anna Arad
no flags
Fixed patch (925 bytes, patch)
2018-08-19 18:27 CEST , Anna Arad
no flags
Patch (1.22 KB, patch)
2018-08-21 10:51 CEST , Anna Arad
no flags

Additional information