! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Suggestion] Separate icons for app and panel
Status:
RESOLVED: MOVED
Product:
Xfce4-notes-plugin
Component:
General

Comments

Description Spass 2018-08-02 12:28:53 CEST
Created attachment 7855 
(just in case link from the post doesn't work)

Hello, currently xfce4-notes-plugin (1.8.1) uses the same icon as xfce4-notes application, so the icon named "xfce4-notes-plugin". This is in my opinion wrong behaviour and those icons should be separated. Many modern and popular icon themes are displaying those icons incorrectly, the only icon set I could find that managed to do it properly is Xubuntu's elementary-xfce, but ochosi used some "Kung Fu" workaround to achieve that ;) Most icon theme creators don't know how to handle that situation and I can't blame them.
See this screen - https://ibb.co/nPXxrK

My suggestion:
- xfce4-notes application (entry visible in the Whisker Menu) should use icon named "xfce4-notes", with a fallback to "xfce4-notes-plugin" if possible
- xfce4-notes-plugin (so the icon visible on the panel) should use icon named "xfce4-notes-plugin" (so no changes here)

...so if I'm not mistaken, the only change needed is to change xfce4-notes.desktop "Icon=xfce4-notes-plugin" to "Icon=xfce4-notes" and inform about that in the changelog.
https://git.xfce.org/panel-plugins/xfce4-notes-plugin/tree/src/xfce4-notes.desktop.in

The other option is (possibly? I'm not a dev...) to change - image = new Xfce.PanelImage.from_source ("xfce4-notes-plugin");
to something like - image = new Xfce.PanelImage.from_source ("xfce4-notes-plugin-panel","xfce4-notes-plugin");
here https://git.xfce.org/panel-plugins/xfce4-notes-plugin/tree/src/main-panel-plugin.vala
to not break current themes, then the icon theme creators could just add new icon "xfce4-notes-plugin-panel" to change the panel icon.

That would make things much easier for theme creators. Many users (me included) want their tray icons to be monochrome and consistent.
Comment 1 Spass 2018-08-02 20:33:04 CEST
My second suggestion with adding "xfce4-notes-plugin-panel" icon name to the code might be a better solution.

Here's what the creator of Papirus, one of the most popular icon theme, has to say:
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/1418#issuecomment-410019800
And here: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/issues/255
Comment 2 Git Bot editbugs 2020-05-23 00:29:14 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-notes-plugin/-/issues/40.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14573

Reported by:
Spass
Reported on: 2018-08-02
Last modified on: 2020-05-23

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information