! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[LP] Missing confirmation dialog to avoid the loss configurations
Status:
RESOLVED: FIXED
Product:
Xfce4-panel-profiles
Component:
General

Comments

Description Sean Davis editbugs 2018-07-28 12:34:39 CEST
From https://bugs.launchpad.net/xfpanel-switch/+bug/1778654

The possibility to easily backup the xfce panelconfigurations and easily switch between configurations is great!

But choosing "Apply configuration" I would expect a confirmation dialog remembering to make a backup of the current configuration.

Better: offer to create such backup in the confirmation dialog

The icon on the "apply"-button is very similar to many "configure" or "property"-icons in other applications. Finding the Xfce Panel Switch between other xfce configuration tools without knowing them may lead to the mistake that I can configure anything instead of apply (what's happend to me...).

(I had help to restore my custom configurations from backup files. Now the first Thing I will do is to save my configurations with Xfce Panel Switch ;-)
Comment 1 ema-pe 2019-09-22 11:32:06 CEST
Created attachment 9047 
Add a confirmation dialog before applying a configuration

Hi!

I resolved this issue by adding a confirmation dialog before applying a configuration. I also added a checkbox to make a backup of current configuration.

This is my first contribution and my first time I use PyGObject, so if there are any errors I will try to fix them!
Comment 2 Git Bot editbugs 2019-12-19 03:34:26 CET
Emanuele Petriglia referenced this bugreport in commit a440127d0cd90e18bdd193af37d31b61c5eebd19

Add a confirmation dialog and option to create a backup before applying (bug #14559)

https://git.xfce.org/apps/xfce4-panel-profiles/commit?id=a440127d0cd90e18bdd193af37d31b61c5eebd19
Comment 3 Sean Davis editbugs 2019-12-19 03:34:49 CET
This patch is great! Applied above.

Bug #14559

Reported by:
Sean Davis
Reported on: 2018-07-28
Last modified on: 2019-12-19

People

Assignee:
Sean Davis
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information