! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Cell renderer hover and selection effects broken
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Settings Manager

Comments

Description Simon Steinbeiss editbugs 2018-07-16 21:45:49 CEST
The cell renderer in xfce4-settings-manager/xfce-text-renderer.c should handle the hover effect (as it does in 4.12 / Gtk+2), but this behavior is currently broken in 4.14.
Comment 1 Simon Steinbeiss editbugs 2018-07-16 22:34:45 CEST
I realized after reading the code that this is connected to a FIXME related to using XfceTextRenderer again.

Currently this custom renderer (which provided the hover effects) is not used and if trying to use it as is, it's broken.

We should either look into using some more modern widget which also allows filtering (e.g. gtkflowbox seems like an ideal candidate) or really revive the custom renderer.
Comment 2 Simon Steinbeiss editbugs 2018-07-17 23:36:46 CEST
This bug is tackled in this branch: https://git.xfce.org/users/ochosi/xfce4-settings/log/?h=fix_hover_effect

Please test.
Comment 3 Git Bot editbugs 2018-07-18 00:20:27 CEST
Simon Steinbeiss referenced this bugreport in commit 57987f3e8ecee0f95effe0e98d773e517b54c3ee

Fix broken hover effect in the settings manager (Bug #14539)

https://git.xfce.org/xfce/xfce4-settings/commit?id=57987f3e8ecee0f95effe0e98d773e517b54c3ee
Comment 4 Simon Steinbeiss editbugs 2018-07-18 00:20:53 CEST
Tested, reviewed and pushed to master.

Bug #14539

Reported by:
Simon Steinbeiss
Reported on: 2018-07-16
Last modified on: 2018-07-18

People

Assignee:
Simon Steinbeiss
CC List:
4 users

Version

Version:
4.13.0

Attachments

Additional information