! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add german (and custom) date format
Status:
RESOLVED: FIXED

Comments

Description zezo 2018-07-09 13:44:59 CEST
Hi,

i `m using thunar 1.6.12 under MX-17.1_x64, Desktop: Xfce 4.12.3.

My wish, because sometimes you can`t move an old tree like me, is to change the format of date.
Is there a way to see only 08.07.18 14:02?

The only choices thunar give me, are:

Today
Today at 14.03.38
Su 08 jul 2018 14:03:38 Cest   .... omg ;-)
2018-07-08 14:03.38

That is a point like reading, better not reading, an analog watch.
You just have a look and know the time without reading!

Thank you

https://framapic.org/o5DtHxvtNB8F/OTF3kItrIAGk.png
Comment 1 Spass 2018-07-09 23:09:22 CEST
I would like to suggest adding another option to choose - "Custom format" - so users could entry their own desired format, so for example something like "%d.%m.%y %H:%M". It could look similar to the Clock panel item settings, you can see it here - https://ibb.co/iJc0Bo
Comment 2 alexxcons editbugs 2018-07-10 21:56:32 CEST
Agreed, I as well think a format like "DD.MM.YYYY  - HH::MM::SS" is missing (you are lucky that I am german) .. added the issue to my personal Thunar TODO-List ... hope I will have time to work on it soon .. should be rather easy to implement.

@Spass: 
IMO for thunar this would be over-engeneering, and for sure it would be  quit a bit of work ... however if you have time to work on it,  like always, patches are welcome !
Comment 3 alexxcons editbugs 2018-07-16 00:40:42 CEST
Created attachment 7833 
more formats + custom

.. dont know what happened, somehow I felt like adding as well the custom-format part.  ;)
It's not perfect, but already works.
I have to polish it a bit more before pushing it to master. Currently known issues:
- "custom" should start hidden if something non-custom is selected
- missing tooltip to explain supported formats
- prettify code 

Would be great if you could test the patch, and report additional issues, if found !
Comment 4 alexxcons editbugs 2018-07-17 21:54:22 CEST
Created attachment 7837 
patch

fixed remaining issues, to be tested by somebody else.
Comment 5 alexxcons editbugs 2018-07-17 22:35:18 CEST
Created attachment 7838 
patch

added note for translators
Comment 6 Andre Miranda editbugs 2018-07-18 04:58:51 CEST
Created attachment 7839 
patch complement

Looks pretty good to me, I wasn't even expecting the custom format, awesome work!

The attached patch is meant to be applied over yours, no need to make a separated commit or attribute credits to me. The changes are:
- indentation fixes
- make "Custom" translatable
- improving wording in translators' notes
- improvements to the tooltip, tabs are evil!!! https://i.imgur.com/hubbGtH.png
Comment 7 zezo 2018-07-18 10:31:28 CEST
alexxcons, this looks perfect!

I mean the screenshot, because i don`t know how to patch. 
Searching google "how to patch...", results are to much for me ;-)
Comment 8 Andre Miranda editbugs 2018-07-18 13:53:12 CEST
@zezo, it is as straightforward as:

git clone git://git.xfce.org/xfce/thunar
cd thunar
curl https://bugzilla.xfce.org/attachment.cgi?id=7838 | git apply # alex's patch
curl https://bugzilla.xfce.org/attachment.cgi?id=7839 | git apply # my patch
./autogen.sh # you might need to install development packages
make
pkill -i thunar # kill thunar daemon (do not run this while moving files)
thunar/thunar
Comment 9 zezo 2018-07-18 15:30:38 CEST
thank you for taking me by the hand ;-)

your tut working good up to 

$ ./autogen.sh
xdt-autogen: You must have "autoconf" 
Ok
xdt-autogen: You must have "intltool" 
Ok
xdt-autogen: You must have "libtool"
OK
xdt-autogen: You must have "glib2" 

and here i stopped, someone asked for security passwort i did not have. 
root or user pass did not work.

I think i better wait for thunar update.
3 month ago i coming from windows to linux, not so easy ;-)
Comment 10 Andre Miranda editbugs 2018-07-18 16:22:46 CEST
Indeed sorting out the missing dependencies and their respective packages for your distro is the trickiest part.

If you are using a "rolling release" distribution such as Arch Linux, you'll get the latest Thunar very soon, on the other hand for more "stable" distributions such as Debian or Ubuntu LTS, forget about this feature, it'll take a year or more :-)

I hope you are enjoying your Linux experience, specially with regards to Xfce ;)
Comment 11 alexxcons editbugs 2018-07-18 21:36:49 CEST
Created attachment 7841 
patch complement 2

Thanks again for the review and the patch !

As discussed in irc, here some more adjustments:
- renamed iso, iso_eu and iso_us
- use yyyymmdd as default for custom
Comment 12 Git Bot editbugs 2018-07-18 21:50:18 CEST
Alexander Schwinn referenced this bugreport in commit 863cd9efdcb8b71aae82b206b998ec678ec1069b

Add german (and custom) date format (Bug #14527)

https://git.xfce.org/xfce/thunar/commit?id=863cd9efdcb8b71aae82b206b998ec678ec1069b
Comment 13 Git Bot editbugs 2018-07-18 22:07:44 CEST
Alexander Schwinn referenced this bugreport in commit 6a22d059527165f9d081501e66cfafd720698395

Add german (and custom) date format (Bug #14527)

https://git.xfce.org/xfce/thunar/commit?id=6a22d059527165f9d081501e66cfafd720698395
Comment 14 alexxcons editbugs 2018-07-18 22:20:28 CEST
Fixed. Will be released in thunar 1.8.2

@zezo:
Hope you can figure out this security password thing ... never saw something like that on package install. You are sure you picked the dev-version of the correct package ?  ... best check if your distribution already ships thunar 1.8.x and/or when the next release of the distribution is planned.

If you need further help: https://xfce.org/community
Comment 15 alexxcons editbugs 2018-07-18 22:28:30 CEST
*** Bug 13867 has been marked as a duplicate of this bug. ***
Comment 16 zezo 2018-07-19 11:28:38 CEST
@ Andre Miranda

I use MX Linux 17.1, 
I`m not the youngest ----- think i will experience an thunar update ;-)

My Linux experience: Just great! 
Never booting so fast, running quick, easy and reliable upt to know.
On the other side, microsoft makes it in the last time easy for me to change.

@alexxcons
figured out the password thing.

It was the stupid user in front of screen, only thunderbird was running in background and asking for pass ;-)

MX has thunar 1.6.12. They are very quick up to now with updates, saying as a newbie! So we see, i`m not in a hurry.

At weekend i will try patch again ...
Comment 17 bugs1 2018-07-23 14:56:17 CEST
I've compiled thunar from master, and it works perfect.
Many thanks for that, after all these many years with xfce, finally a "german date".

regards
MB
Comment 18 alexxcons editbugs 2018-07-23 21:09:32 CEST
Glad you like it ;)
Comment 19 zezo 2018-07-24 09:13:11 CEST
me too, now with german date :-)
Thank you !

Bug #14527

Reported by:
zezo
Reported on: 2018-07-09
Last modified on: 2018-07-24

People

Assignee:
alexxcons
CC List:
6 users

Version

Version:
1.6.12

Attachments

more formats + custom (23.23 KB, patch)
2018-07-16 00:40 CEST , alexxcons
no flags
patch (24.73 KB, patch)
2018-07-17 21:54 CEST , alexxcons
no flags
patch (24.85 KB, patch)
2018-07-17 22:35 CEST , alexxcons
no flags
patch complement (4.96 KB, patch)
2018-07-18 04:58 CEST , Andre Miranda
no flags
patch complement 2 (5.74 KB, patch)
2018-07-18 21:36 CEST , alexxcons
no flags

Additional information