Created attachment 7820 Wrong border in Thunar-1.8.1 with any theme Wrong border in Thunar-1.8.1 with any theme Steps to reproduce: Drag any file/folder to thunar with opened tabs System: Arch (fresh install)
Thanks for reporting ! Can reproduce it on Debian stretch / thunar master. crap, cant believe that I never tested that. WIll take a look on it when I have time
> WIll take a look on it when I have time Ok. Thanks!
This issue exists since at least 1.7.0, funny no one noticed until now. This inner border is rendered by thunar_standard_view_draw when drop_highlight is true. These are the dimensions of standard view: No tabs -> x: 0, y: 0, w: 869, h: 549 With tabs-> x: 0, y: 34, w: 869, h: 515 I hard-coded the y value as 0 and it seems works well, though it feels kinda hack. Another approach is to introduce a style class, e.g. "dnd-target", with "border: 1px solid black;" and toggle it for standard view based on the value of drop_highlight. However, the border property can somehow be overridden by the theme. Alex, what do you think?
Thanks for taking care Andre ! I would prefer the first approach, sounds simple and straight forward. Hard-coding 0 IMO is fine .. at least I dont consider 0 to be a "magic-number" It's more like the default ;) I would define it on top of the file with some meaningful name. E.g. REAL_ALLOCATION_Y ? So far I was not able to figure out why allocation.y is a lie in the fist place.
Andre Miranda referenced this bugreport in commit 97ef840803e61d425cf18f260caa06ddbd068797 Fix standard view border during drag and drop (Bug #14523) https://git.xfce.org/xfce/thunar/commit?id=97ef840803e61d425cf18f260caa06ddbd068797
Andre Miranda referenced this bugreport in commit 203029e4dd1bf1b132e15f4b9b79e93ef269e48f Fix standard view border during drag and drop (Bug #14523) https://git.xfce.org/xfce/thunar/commit?id=203029e4dd1bf1b132e15f4b9b79e93ef269e48f