! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use GenericName in a correct way
Status:
RESOLVED: MOVED

Comments

Description Stanislav Brabec 2018-06-28 21:57:53 CEST
XFCE Application Menu supports both GenericName and Comment desktop file entries.

But its use is not correct. If both Comment and GenericName are present, application subtitle should use GenericName and pop-up should use Comment.

Current behavior:
Title: Uses name
Subtitle: If Comment is available, use Comment, else use GenericName.
Pop up:  If Comment is available, use Comment, else use GenericName.
=> Subtitle and Pop up are always the same

Expected behavior:
The subtitle logic should be reversed.
Subtitle: If GenericName is available, use GenericName, else use Comment.

xfce4-panel-4.12.2, openSUSE Tumbleweed current for x86_64.
Comment 1 Andre Miranda editbugs 2018-06-29 03:20:04 CEST
I think this is an improvement for Garcon, it seems all application menu does is to toggle generic names and tooltips:
https://git.xfce.org/xfce/xfce4-panel/tree/plugins/applicationsmenu/applicationsmenu.c#n309

Reading garcon's code, I couldn't find anything resembling the logic you described, here's the code that uses the Name or GenericName:
https://git.xfce.org/xfce/garcon/tree/garcon-gtk/garcon-gtk-menu.c#n853

If you're able to provide a patch improving this behavior, I will gladly review it :)
Comment 2 Git Bot editbugs 2020-05-25 22:48:08 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/garcon/-/issues/6.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14480

Reported by:
Stanislav Brabec
Reported on: 2018-06-28
Last modified on: 2020-05-25

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

Additional information