Created attachment 7808 A screenshot of the two dialogues When I drag and drop an URL from the address bar of Firefox to my desktop I sometimes have two identical dialogues instead of one. This only seems to be a problem when dragging and dropping to the desktop. Drag 'n drop to a Thunar window seems fine. Strangely the bug isn't always reproducible. You have to try it multiple times (roughly 10 times on average) to trigger the bug. For example I can trigger the bug sometimes with this link: https://www.amazon.de/Intos-Premium-Kabel-mDIN6-Stecker/dp/B000VF9JH4/ref=pd_sim_147_2?_encoding=UTF8&pd_rd_i=B000VF9JH4&pd_rd_r=47bfe486-746f-11e8-91d2-2124ac1acc34&pd_rd_w=939zS&pd_rd_wg=Cnrs0&pf_rd_i=desktop-dp-sims&pf_rd_m=A3JWKAKR8XB7XF&pf_rd_p=5296994838746851949&pf_rd_r=KBZVBX3S2JT7MX6R6WJZ&pf_rd_s=desktop-dp-sims&pf_rd_t=40701&psc=1&refRID=KBZVBX3S2JT7MX6R6WJZ In the screenshot attached the dialogues are side by side because I placed them side by side. But when the bug triggers the dialogues are exactly on top of each other. So please keep this in mind when trying to trigger the bug :) At first I thought this is a problem only to my desktop because I compiled exo by myself with some changes in the code. But then I tested with the live disk of Xubuntu 18.04 64 bit and the bug is there too. Can anybody else reproduce this?
I was also able to trigger the bug with the URL of this bug report.
Maybe simply my mouse is broken. I will try to test this with a different one.
Okay, now I tested with a different mouse and the bug is still there. I think the only problem is to trigger the bug. Sometimes you have to create over 20 bookmarks until the bug appears.
I tested with Xubuntu 19.04 (xfdesktop 4.13) and was able to trigger this bug after several attempts.
I can't reproduce, I tried to drag the link of this bug more than 10 times, only one dialog appeared. There were changes to URL DnD recently, by chance can you guys try the git master?
It still happens. While testing I noticed that the panel does not show a window button for exo's "Create Link" dialog anymore.
After dropping the URL immediately move the cursor a bit further and left-click several times.
Created attachment 8650 patch This patch fixes the bug for me.
Theo Linkspfeifer referenced this bugreport in commit 77ceeadaa5c5a2dfabc795af3c7d08237812b0a7 Fix drag data being received multiple times (Bug #14471) https://git.xfce.org/xfce/xfdesktop/commit?id=77ceeadaa5c5a2dfabc795af3c7d08237812b0a7
I was able to reproduce the bug on another machine, it took no more than 12 attempts to get a double dialog, I could consistently repeat the operation. The patch worked for me too, thanks.
Theo Linkspfeifer referenced this bugreport in commit e462a1aee91fccb77afa354dc1e69442569f21cf Fix drag data being received multiple times (Bug #14471) https://git.xfce.org/xfce/xfdesktop/commit?id=e462a1aee91fccb77afa354dc1e69442569f21cf
Seems to work for me too. Many thanks for the patch :) Can't believe we have fixed this patch which was so hard to trigger.
I mean "fixed this bug" not "fixed this patch"...