! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar toolbar: add separator after home button
Status:
RESOLVED: WONTFIX

Comments

Description Tomasz Gąsior 2018-06-19 22:23:25 CEST
This bug post is an continuation of discussion in comments. https://andreldm.com/2018/06/06/thunar-1.8.0-release.html#comment-3950314142

me:
> Please add separator between home button and pathbar — it will be good looking. Thanks for work.

André Miranda:
> Here's a preview of you suggestion: https://i.imgur.com/Be7Apd6.png
> Not so sure it looks good, takes a bit of space, maybe we could add a css class and that separator could be set or not depending on the theme. Please file a bug requesting this, so we can evaluate it more carefully.

In my opinion version with separator added looks much better than without separator. Please see this screenshot:
https://i.imgur.com/p81TzTu.png
There is Engrampa (Mate's file-roller fork) under Thunar window for comparison.
I think separator should be forced (without ability to disable it) because currently pathbar is too close to last button (home button).
Comment 1 Andre Miranda editbugs 2018-06-20 04:33:18 CEST
Created attachment 7805 
Separator patch

The attached patch accomplishes what is requested.
However, let me first collect feedback before pushing this change.
Comment 2 alexxcons editbugs 2018-06-20 09:39:16 CEST
IMO it looks better without seperator :F
Comment 3 alexxcons editbugs 2018-06-20 09:42:03 CEST
IMO best would be to just have some additional space instead of a separator ... but actually I dont care too much about it.
Comment 4 Simon Steinbeiss editbugs 2018-06-20 19:43:46 CEST
Not sure that separator helps at all. The visual separation between the buttons and the gtkentry is really ok in most themes, so the separator feels superfluous.

Themes can add more space by adding padding anyways, so not sure if I'd do anything about that in Thunar itself.
</my2cents>
Comment 5 Alexander Butenko 2018-06-20 19:44:28 CEST
imho version without separator looks better but i can live with separator just fine. no strong preferences
Comment 6 Andre Miranda editbugs 2020-05-21 03:54:14 CEST
Closing since more people prefer toolbar without separator.

Bug #14468

Reported by:
Tomasz Gąsior
Reported on: 2018-06-19
Last modified on: 2020-05-21

People

Assignee:
Xfce Bug Triage
CC List:
6 users

Version

Attachments

Separator patch (350 bytes, patch)
2018-06-20 04:33 CEST , Andre Miranda
no flags

Additional information