! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
taskmanager crashes when killing conky


Description Andre Miranda editbugs 2018-06-19 04:01:46 CEST
Steps to reproduce:
- Launch a couple of "conky -d"
- Open xfce4-taskmanager and try to kill any of the conky processes

Expected results:
- conky is killed and taskmanager is still running

Actual results:
- conky is killed but taskmanager crashes

taskmanager built from git master, makes no difference if using gtk2 or gtk3.

Thread 1 "xfce4-taskmanag" received signal SIGSEGV, Segmentation fault.
0x00005555555692d3 in app_get_pid (application=0x555555d6f0d0) at app-manager.c:105
105		return (wnck_window_get_pid (WNCK_WINDOW (wnck_application_get_windows (application)->data)));
(gdb) bt
#0  0x00005555555692d3 in app_get_pid (application=0x555555d6f0d0) at app-manager.c:105
#1  0x0000555555569312 in apps_remove_application (application=<optimized out>, apps=0x7fffdc014700)
    at app-manager.c:135
#2  0x0000555555569312 in application_closed (screen=<optimized out>, application=<optimized out>, manager=<optimized out>) at app-manager.c:165
#3  0x00007ffff4dd9cca in g_cclosure_marshal_VOID__OBJECTv () at /usr/lib/libgobject-2.0.so.0
#4  0x00007ffff4dd6c96 in  () at /usr/lib/libgobject-2.0.so.0
Comment 1 Andre Miranda editbugs 2018-06-19 04:05:54 CEST
Created attachment 7800 

The attached patch seems to fix the problem, though I'm not sure if it's safe to just return pid 0.
Comment 2 Andre Miranda editbugs 2018-06-21 04:24:45 CEST
This crash is caused by changes introduced in this commit:
Comment 3 Landry Breuil editbugs 2018-06-21 07:17:06 CEST
Ivan can you have a look at it ?
Comment 4 Ivan 83 2018-06-21 10:23:49 CEST
Ok, I will see.
Comment 5 Ivan 83 2018-06-21 11:12:14 CEST
Created attachment 7807 

I extend initial attached patch, to prevent resource leak.
Comment 6 Git Bot editbugs 2018-06-22 11:43:23 CEST
rim referenced this bugreport in commit af078d406a43243388e0a61d647c3a6b7ada60ed

Improve app search on close (bug 14466)

Comment 7 Landry Breuil editbugs 2018-06-22 11:44:25 CEST
I havent been able to reproduce the crash before the patch, but it always seem better to check for more return codes :)

Andre, i'll let you close the bug once you confirm master doesnt crash anymore for you..
Comment 8 Andre Miranda editbugs 2018-06-23 03:55:30 CEST
Confirmed, master is not crashing anymore, thanks!

Bug #14466

Reported by:
Andre Miranda
Reported on: 2018-06-19
Last modified on: 2018-06-23


Mike Massonnet
CC List:
2 users



fix.patch (625 bytes, patch)
2018-06-19 04:05 CEST , Andre Miranda
no flags
fix (2.45 KB, patch)
2018-06-21 11:12 CEST , Ivan 83
no flags

Additional information