Steps to reproduce: - Launch a couple of "conky -d" - Open xfce4-taskmanager and try to kill any of the conky processes Expected results: - conky is killed and taskmanager is still running Actual results: - conky is killed but taskmanager crashes taskmanager built from git master, makes no difference if using gtk2 or gtk3. Backtrace: Thread 1 "xfce4-taskmanag" received signal SIGSEGV, Segmentation fault. 0x00005555555692d3 in app_get_pid (application=0x555555d6f0d0) at app-manager.c:105 105 return (wnck_window_get_pid (WNCK_WINDOW (wnck_application_get_windows (application)->data))); (gdb) bt #0 0x00005555555692d3 in app_get_pid (application=0x555555d6f0d0) at app-manager.c:105 #1 0x0000555555569312 in apps_remove_application (application=<optimized out>, apps=0x7fffdc014700) at app-manager.c:135 #2 0x0000555555569312 in application_closed (screen=<optimized out>, application=<optimized out>, manager=<optimized out>) at app-manager.c:165 #3 0x00007ffff4dd9cca in g_cclosure_marshal_VOID__OBJECTv () at /usr/lib/libgobject-2.0.so.0 #4 0x00007ffff4dd6c96 in () at /usr/lib/libgobject-2.0.so.0 ...
Created attachment 7800 fix.patch The attached patch seems to fix the problem, though I'm not sure if it's safe to just return pid 0.
This crash is caused by changes introduced in this commit: https://git.xfce.org/apps/xfce4-taskmanager/commit/?id=621de4fd13b468189a814aa654572e84c47269fe
Ivan can you have a look at it ?
Ok, I will see.
Created attachment 7807 fix I extend initial attached patch, to prevent resource leak.
rim referenced this bugreport in commit af078d406a43243388e0a61d647c3a6b7ada60ed Improve app search on close (bug 14466) https://git.xfce.org/apps/xfce4-taskmanager/commit?id=af078d406a43243388e0a61d647c3a6b7ada60ed
I havent been able to reproduce the crash before the patch, but it always seem better to check for more return codes :) Andre, i'll let you close the bug once you confirm master doesnt crash anymore for you..
Confirmed, master is not crashing anymore, thanks!