Created attachment 7793 gdb backtrace Clicking into the window or pressing keys on my keyboard results in a segfault. I have tested this behavior with arrow keys and letters. Space does not trigger the bug, it just opens the quick search box. Inside the quick search box I can type other characters too, after closing it however it'll crash on the next input. Thunar 1.6.15 works fine, 1.8.1 doesn't. This is running on Arch Linux with Gnome on Wayland.
Thanks for reporting, I'll have a look at "thunarx_menu_provider_get_file_menu_items" when I have time. Possibly a thunarx incompartibility ( thunar plugins need to use the new API ) Could you please take a try to uninstall and/or update all thunar plugins you have installed.
Is there an easy way to see which plugins are interacting with thunar?
Sorry, last time I did not read the stacktrace carefully enough: /usr/lib/thunarx-3/thunar-wallpaper-plugin.so ^^ so this seems to be the problematic plugin thunar-wallpaper-plugin is a thunar internal plugin, it is packaged together with thunar. You installed thunar from source ? My quess would be, that you tried to run thunar from the source-directory while having the old plugins installed, or you only installed thunar itself, but not the plugins. When compiling from source you only can make use of the new plugins by doing "make install" on the main thunar folder. Try to first remove all the old thunar packages of your distro and than build & install thunar like that, while beeing on the main thunar folder: ./autogen.sh make sudo make install ( Hope I was right and you installed from source ? ) Here a list of thunar plugins (besides the thunar-internal plugins) maintained by xfce: https://docs.xfce.org/xfce/thunar/start The according package-names usually are something like "thunar-****-plugin"
I didn't install thunar from source, it's installed from the arch packages: https://www.archlinux.org/packages/extra/x86_64/thunar/ Build script: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/thunar I'll try removing some other plugins I'm using later when I have time.
Richard do you have some custom actions without icon (look in .config/thunar/uca.xml) ?
Richard, I'm running 1.8.1 from Arch packages, but it doesn't crash on Gnome Xorg, I'm not able to make the Wayland session work (no time to investigate). Can you check if it also crashes for you on Xorg or when running a Xfce session?
~/.config/thunar/uca.xml doesn't exist on my system. Ie tried removing thunar-archive-plugin thunar-media-tags-plugin thunar-volman tumbler ffmpegthumbnailer, that didn't make a difference (I didn't reboot after removal, so there may still have been things running in background). I won't be able to reboot and test gnome/x11 until the weekend, I'll have to see if I can do xfce.
Actually ~/.config/Thunar/uca.xml does exist though: <?xml encoding="UTF-8" version="1.0"?> <actions> <action> <icon>utilities-terminal</icon> <name>Open Terminal Here</name> <unique-id>1505138029589936-1</unique-id> <command>exo-open --working-directory %f --launch TerminalEmulator</command> <description>Example for a custom action</description> <patterns>*</patterns> <startup-notify/> <directories/> </action> </actions> Where would that icon have to be? It does exist in /usr/share/icons/<gnome-theme-name>/<various-sizes>/utilities-terminal.png
Those plugins does seem to have any relation, the backtrace tell us the "culprit" is /usr/lib/thunarx-3/thunar-wallpaper-plugin.so. Your uca.xml is fine, it's the default.
Created attachment 7801 unstripped gdb backtrace I've added an unstripped gdb backtrace now.
Ah, much better .. think now it is more or less clear what's the Problem: plugins/thunar-wallpaper/twp-provider.c:183: .... xfce_selection_atom = XInternAtom (gdk_x11_get_default_xdisplay(), selection_name, False); ... gdk_x11_get_default_xdisplay() does not work for wayland. Wonder if it can be replaced by "gdk_display_get_default (void)" .. probably not. I dont run wayland, so I cannot test that. A solution could be to check if it is set: if (!GDK_IS_X11_DISPLAY(display)) return;
Alex's rationale makes sense, it seems wallpaper-plugin needs to be "ported" to wayland, but we cannot promise anything since Thunar itself is not tested on wayland, actually Xfce as whole is far from ready for wayland. What we can do, as a compromise, is to make this plugin kinda disable itself when not running under Xorg.
According to https://goodies.xfce.org/projects/thunar-plugins/start#thunar-wallpaper-plugin the purpose of this plugin is providing an interface to thunar which allows you to set the wallpaper on the xfce desktop. Since I don't use xfce I'd be perfectly fine with that, it wouldn't affect me anyways. I'm curious though why this worked fine with thunar 1.6 though.
Another approach could be to use some gdbus magic to replace the current logic to figure out if desktop_type = DESKTOP_TYPE_XFCE or DESKTOP_TYPE_NAUTILUS ( but I realy have no idea if/how that could be done) .. wonder if the nautilus part works at all ;) Ok, let me just provide a small patch to take a try.
Created attachment 7802 patch to check for wayland The previously suggested check did not work out, so now I try to read an environment variable. Could you please check if $XDG_SESSION_TYPE is really set to "wayland" for you ? ( Or ideally build thunar from source )
XDG_SESSION_TYPE is indeed wayland. After applying that patch (modified the arch repo build script to also apply the patch) it works fine.
Great ! I pushed it to master, will be released in 1.8.2 .. since our git-bot is lazy/down: https://git.xfce.org/xfce/thunar/commit/?id=4fa24d42f83180fd5012527eb4ed77b04e8d88a6
By the way, thanks for reporting this and thanks for the unstripped backtrace ! Nice to see that thunar already runs on wayland !
Alexander Schwinn referenced this bugreport in commit 660d9ceb8509ef82fe3a4a0287014010286bf12c Segfault in XInternAtom when clicking or typing when using wayland ( Part II ) (Bug #14461) https://git.xfce.org/xfce/thunar/commit?id=660d9ceb8509ef82fe3a4a0287014010286bf12c