! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-panel git compile error on Fedora 28
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
General

Comments

Description Ali Akcaagac 2018-06-05 10:59:29 CEST
There was some changes recently that causes compile errors on Fedora 28 Linux (x86_64 + gcc 8.1.1). Please fix if possible.





make[4]: Entering directory '/root/rpmbuild/BUILD/xfce4-panel-4.13.3/plugins/actions'
/bin/sh ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..  -I../.. -DG_LOG_DOMAIN=\"libactions\"  -DNDEBUG -DHAVE_GNUC_VISIBILITY -I/usr/include/gt
LC_ALL=C /usr/bin/intltool-merge  -d -u -c ../../po/.intltool-merge-cache ../../po actions.desktop.in actions.desktop
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../.. -DG_LOG_DOMAIN=\"libactions\" -DNDEBUG -DHAVE_GNUC_VISIBILITY -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -
Generating and caching the translation database
Merging translations into actions.desktop.
actions.c: In function 'actions_plugin_action_activate':
actions.c:1015:7: error: 'path' undeclared (first use in this function); did you mean 'puts'?
       path = g_find_program_in_path ("dm-tool");
       ^~~~
       puts
actions.c:1015:7: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [Makefile:624: libactions_la-actions.lo] Error 1
make[4]: Leaving directory '/root/rpmbuild/BUILD/xfce4-panel-4.13.3/plugins/actions'
make[3]: *** [Makefile:516: all] Error 2
make[3]: Leaving directory '/root/rpmbuild/BUILD/xfce4-panel-4.13.3/plugins/actions'
make[2]: *** [Makefile:487: all-recursive] Error 1
make[2]: Leaving directory '/root/rpmbuild/BUILD/xfce4-panel-4.13.3/plugins'
make[1]: *** [Makefile:609: all-recursive] Error 1
make[1]: Leaving directory '/root/rpmbuild/BUILD/xfce4-panel-4.13.3'
make: *** [Makefile:520: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.OBBDOr (%build)
Comment 1 Ali Akcaagac 2018-06-05 11:09:05 CEST
Created attachment 7769 
Fix for compile issue. Missing variable declaration.
Comment 2 Simon Steinbeiss editbugs 2018-06-06 22:38:43 CEST
Oh hey, thanks for noticing! I also noticed (albeit too late) and pushed the fix: https://git.xfce.org/xfce/xfce4-panel/commit/?id=de100457814328b9a71de8117961b5eec375cc28
Comment 3 Ali Akcaagac 2018-06-06 22:54:50 CEST
No problem. Thanks for fixing it.

Bug #14430

Reported by:
Ali Akcaagac
Reported on: 2018-06-05
Last modified on: 2018-06-06

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information