! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Replace which(1) with "command -v" in xinitrc.in
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Leonid Isaev 2018-05-15 12:11:09 CEST
Created attachment 7729 
Patch to replace which(1) with "command" in xinitrc.in.in

Currently the script xinitrc (placed to /etc/xdg/xfce4/xinitrc in ArchLinux) called by startxfce4 depends in which(1). However, the script has #!/bin/sh shebang, i.e. it's a POSIX sh script, which means that we can use the "command" builtin. This has an advantage of reducing calls to external binaries and remving which(1) dependency. Please consider this replacement, e.g. as in the attached patch.

Thanks!
Comment 1 Andre Miranda editbugs 2018-05-16 03:28:29 CEST
*** Bug 14400 has been marked as a duplicate of this bug. ***
Comment 2 Leonid Isaev 2018-05-16 03:42:13 CEST
Sorry, I have hit the renew button accidentaly...
Comment 3 Git Bot editbugs 2019-05-08 19:06:37 CEST
ISAEV Leonid referenced this bugreport in commit 4c9e19dbb8e0de98d664cd74657e912df8e125c7

scripts/xinitrc.in.in: use "command" shell builtin instead of which(1)

https://git.xfce.org/xfce/xfce4-session/commit?id=4c9e19dbb8e0de98d664cd74657e912df8e125c7

Bug #14399

Reported by:
Leonid Isaev
Reported on: 2018-05-15
Last modified on: 2019-05-10
Duplicates (1):
  • 14400 Replace which(1) with "command -v" in xinitrc.in

People

Assignee:
Skunnyk
CC List:
6 users

Version

Version:
4.13.0

Attachments

Additional information