! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Mount point has 32 character limit.
Status:
RESOLVED: FIXED
Product:
Xfce4-fsguard-plugin
Component:
General

Comments

Description flocculant 2018-04-29 22:35:52 CEST
Created attachment 7689 
remove character limit

Currently the mount setting in the plugin has a 32 character limit.

Dealing with a user in xubuntu support who was trying to use this for a partition accessed via samba meant they failed to do so.

Locally I tried to mount a folder in a partition - found the same thing.

Attached patch removes the limitation.

Tested locally and it works.
Comment 1 Simon Steinbeiss editbugs 2018-04-30 00:54:04 CEST
I agree with the patch.

I'm also wondering whether the 16px limit for choosing the name (a few lines below) is necessary.
> gtk_entry_set_max_length (GTK_ENTRY (entry3), 16);

It might be ok to drop that too.
Comment 2 flocculant 2018-04-30 20:52:56 CEST
If one uses the name option - and then uses all of the 16 available characters.

I assume that if one wanted to watch more than one partition  - you'd need more than one plugin in the panel:

that looks not nice
Comment 3 flocculant 2018-04-30 20:53:20 CEST
Created attachment 7692 
long name fsguard
Comment 4 Landry Breuil editbugs 2018-04-30 22:11:42 CEST
Well the name is an option so noone *needs* to use it, i dont really see a problem with the actual 16 char limit for the name.  I've pushed your patch to master in e5f380754, but will leave the bug open if simon wants to discuss it more :)
Comment 5 Simon Steinbeiss editbugs 2018-04-30 23:29:54 CEST
Nah, I'm fine with the limit on the name. I just felt like mentioning it because I noticed ;)

The more important part was really the functional fix anyway.
Comment 6 Landry Breuil editbugs 2018-05-01 10:23:12 CEST
Good, closing then :)

Bug #14367

Reported by:
flocculant
Reported on: 2018-04-29
Last modified on: 2018-05-01

People

Assignee:
Landry Breuil
CC List:
1 user

Version

Version:
unspecified

Attachments

remove character limit (868 bytes, patch)
2018-04-29 22:35 CEST , flocculant
no flags
long name fsguard (27.76 KB, image/png)
2018-04-30 20:53 CEST , flocculant
no flags

Additional information