Created attachment 7636 Silly screencast of the issue :P If I open a new terminal window, create two new tabs, and then move the third tab before the second: 1) The order in the "Tabs" menu is not updated and shows incorrect Alt+<n> shortcuts for all but the first tab and 2) If I click on the first tab and then on the second, right clicking does not bring up a context menu and any typed characters end up in the right-most tab! Probably related to bug 14247 and/or its fix. I noticed this issue because right clicking would randomly stop working while I had several tabs open (and reordering them).
Igor referenced this bugreport in commit 61d9d0d58d53214bdedd2220fb3522c5440a6231 Fix handling of tabs reordering https://git.xfce.org/apps/xfce4-terminal/commit?id=61d9d0d58d53214bdedd2220fb3522c5440a6231
Thanks, Evangelos! Don't know why I did that change that broke the functionality. I've reverted it, and things seem to be fine now.
Can confirm that the order of the tabs remains correct upon reordering, thanks! One cosmetic issue I notice is that, after moving the third tab over the second, the first tab will appear selected in the Tabs menu even though that is not the active tab. Perhaps this explains why you added the call to terminal_window_update_actions() in the fix for bug 14247?
Thanks! I think that really was the problem I tried to solve with that change. I will look into it further and hopefully find a way how to update the active tab indication.
Igor referenced this bugreport in commit 9cfd52b8b5bd1321e2b6f497a41914c5bd06ded4 Update window actions and active tab indication on reordering tabs https://git.xfce.org/apps/xfce4-terminal/commit?id=9cfd52b8b5bd1321e2b6f497a41914c5bd06ded4
Evangelos, could you please test the latest commit? Everything seems to be working fine for me.
Looks good here too, thanks Igor. 🎉
Thank you for reporting the problem!