! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Fix gtk 3.22 deprecations
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
General

Comments

Description Andre Miranda editbugs 2018-03-10 20:00:28 CET
Created attachment 7634 
patch

The attached patch fixes the following deprecations:
gdk_error_trap_push -> gdk_x11_display_error_trap_push
gdk_error_trap_pop -> gdk_x11_display_error_trap_pop
gdk_error_trap_pop_ignored -> gdk_x11_display_error_trap_pop_ignored
gdk_flush -> gdk_display_flush

And silenced these deprecations:
gdk_screen_width
gdk_screen_height

Here's an example on how to properly replace these function: https://github.com/cogniti/nimf/pull/29/files
But I think it's way too convoluted, we should keep them around until gtk 4.

All replacements were introduced in gdk 3.0, I'm sure if this component allows building with gtk2, if so macros will be needed.
Comment 1 Git Bot editbugs 2018-03-15 02:24:49 CET
Sean Davis referenced this bugreport in commit c6c7ca212de9d4fa93d3cd05b22a4a3c8bfaec0c

Fix gtk 3.22 deprecations (Bug 14273)

https://git.xfce.org/xfce/xfce4-settings/commit?id=c6c7ca212de9d4fa93d3cd05b22a4a3c8bfaec0c
Comment 2 Sean Davis editbugs 2018-03-15 02:25:20 CET
Thanks for the patch! Seems to work just fine, applied above.
Comment 3 Sean Davis editbugs 2018-03-15 02:25:33 CET
See above.

Bug #14273

Reported by:
Andre Miranda
Reported on: 2018-03-10
Last modified on: 2018-03-15

People

Assignee:
Nick Schermer
CC List:
4 users

Version

Version:
4.13.0

Attachments

patch (37.24 KB, patch)
2018-03-10 20:00 CET , Andre Miranda
no flags

Additional information