! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add "Undo" to file operations


Description cipricus 2018-03-02 13:07:46 CET
I think this would be very useful to be able to undo an operation after the "Rename Files" button has been clicked. It will avoid taking new action with Bulk Rename to restore previous names modified by error but especially it would be the only recourse in some cases of error like, for example, when text/character has been:

- removed according to character position

- replaced by nothing 

- replaced by text/character that is present in other positions where it must not be changed

Comment 1 cipricus 2018-03-02 13:14:31 CET
When character/text has been removed according to charters position - one that was not the same in all filenames modified (imagine six-digit different numbers at the end of every filename) - it is impossible to restore otherwise.
Comment 2 cipricus 2018-03-02 13:17:00 CET
My posting here doesn't have an "undo" option either. Sorry for the spelling errors ("charters position" - I mean "characters")...
Comment 3 alexxcons editbugs 2018-03-02 21:02:56 CET
*** Bug 14258 has been marked as a duplicate of this bug. ***
Comment 4 alexxcons editbugs 2018-03-02 21:03:03 CET
*** Bug 14257 has been marked as a duplicate of this bug. ***
Comment 5 alexxcons editbugs 2018-03-02 21:21:05 CET
I dont like the "undo" feature much. IMO it is not the job of a file browser to recover lost information, regular backups should cover that.

Specially for the bulk renamer you already have a list of "new names", so you can check what it will look like before pushing "rename".

Last but not least I think undo is rather "heavy" to implement. You always would need to handle an array of filenames instead of a single one for each file.
Comment 6 alexxcons editbugs 2018-03-04 10:50:44 CET
To sum it up: I dont agree with the feature, since IMO it does not fit to the minimalistic approach of xfce.

I as well discussed with another xfce-dev which has the same opinion on it.

However, if you like, we are open for further discussion.
Comment 7 cipricus 2018-03-05 23:54:05 CET
No further discussion is needed I think: I do not consider a valid line of argument  the liking or disliking as such; but Thunar or the renamer itself becoming too heavy or the effort required involving too many changes and/or effort seem to me valid reasons not to accept this request.

My intention was just to inquire on the possibility of it.

On the other hand, many file managers, just like text editors, have the undo option, and I find that a very useful tool indeed in all occasions. But that might be a subjective stand.
Comment 8 Jack 2018-03-24 17:26:21 CET
I'll add to it:

Thunar is basically the best I've found, but lacking undo leads me to some serious problems. Sometimes I'm dragging many items and if my mouse slips, files get distributed in crazy places, which can sometimes take a LONG time to undo manually.

The situation is even worse if it's a sync'd folder, because it starts propagating big changes across all my devices (ack!).

I realize here there is only the suggestion for rename undos, but I'll say that if Thunar had undos, it'd be the best.


PS- I currently use Caja for this reason, but that leads to silliness when I try to copy an item to or from the desktop, which is using Thunar underneath, plus duplicating efforts. Only a minor irritant, but enough to lose the overall elegance of the XFCE experience.
Comment 9 Andre Miranda editbugs 2018-05-05 23:19:29 CEST
The request to add an Undo option to bulk renamer is not acceptable because it's beyond the plugin responsibility to keep track of the file names.
However, requesting Thunar itself to allow undo file operations (rename, copy, move...) make much more sense.
Comment 10 dani 2019-10-15 06:59:14 CEST
However, requesting Thunar itself to allow undo file operations (rename, copy, move...) make much more sense.

This is especially useful with accidental movements.
Comment 11 Git Bot editbugs 2020-05-26 23:34:46 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/thunar/-/issues/191.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14259

Reported by:
Reported on: 2018-03-02
Last modified on: 2020-05-26
Duplicates (2):
  • 14257 "Undo" option in Bulk Rename
  • 14258 "Undo" option in Bulk Rename


Xfce Bug Triage
CC List:
7 users




Additional information