! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
statfs() on IRIX 6.5
Status:
CLOSED: FIXED
Product:
Thunar-vfs
Component:
General

Comments

Description Daichi Kawahata editbugs 2006-02-03 13:49:28 CET
An another problem just arrives.

thunar-vfs-info.c: In function 'thunar_vfs_info_get_free_space':
thunar-vfs-info.c:243: error: too few arguments to function 'statfs'
thunar-vfs-info.c:247: error: 'struct statfs' has no member named 'f_bavail'

I've encountered same problem in the xfce-goodies already,
from what I've seen, it may require some additional checks
in the configure, `#ifdef blah' in this source.
Comment 1 Daichi Kawahata editbugs 2006-02-03 13:52:33 CET
Created attachment 433 
It isn't even dirty patch

That is, it doesn't resolve a problem while working here
(Thunar shows available spaces correctly per each mounted
volumes).
Comment 2 Daichi Kawahata editbugs 2006-02-03 13:56:58 CET
Created attachment 434 
Created config.h file

That is my configuration in which you'll find IRIX has
both statfs and statvfs. Do you need headers for them
(/usr/include/sys/statfs.h, /usr/include/sys/statvfs.h)?
Comment 3 Benedikt Meurer editbugs 2006-02-03 23:09:58 CET
I was expecting this report. :-)

IRIX has a statfs(2) function, but it's not compatible with the 4.4BSD one
(*surprise*).

Can you attach the statvfs(2) manual page please?
Comment 4 Daichi Kawahata editbugs 2006-02-03 23:24:11 CET
Created attachment 435 
Man page of statfs(2)

Here it is.
Comment 5 Daichi Kawahata editbugs 2006-02-03 23:25:30 CET
Created attachment 436 
Man page of statvfs(2)

And man page for statvfs(2).
Comment 6 Benedikt Meurer editbugs 2006-02-03 23:30:54 CET
Created attachment 437 
Suggested fix

Ok, please try the attached patch.
Comment 7 Daichi Kawahata editbugs 2006-02-03 23:57:24 CET
Compilation passed, free-space is shown in Thunar properly.
Comment 8 Benedikt Meurer editbugs 2006-02-04 00:34:48 CET
Committed with revision 19735.

2006-02-04	Benedikt Meurer <benny@xfce.org>

	* thunar-vfs/thunar-vfs-info.c(thunar_vfs_info_get_free_space): Be sure
	  to use statvfs(2) for IRIX. Bug #1425.

Bug #1425

Reported by:
Daichi Kawahata
Reported on: 2006-02-03
Last modified on: 2010-11-07

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
unspecified

Attachments

It isn't even dirty patch (626 bytes, patch)
2006-02-03 13:52 CET , Daichi Kawahata
no flags
Created config.h file (7.30 KB, text/plain)
2006-02-03 13:56 CET , Daichi Kawahata
no flags
Man page of statfs(2) (3.94 KB, text/plain)
2006-02-03 23:24 CET , Daichi Kawahata
no flags
Man page of statvfs(2) (6.16 KB, text/plain)
2006-02-03 23:25 CET , Daichi Kawahata
no flags
Suggested fix (808 bytes, patch)
2006-02-03 23:30 CET , Benedikt Meurer
no flags

Additional information