! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix a couple of warnings
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Olivier Duchateau 2018-02-26 21:54:40 CET
Created attachment 7620 
Fix a couple of warnings

Fix the latest releases (0.8.7 and 0.8.7.1) I noticed some warnings. Patch fixes some of them:

- With vte > 0.48 vte_terminal_spawn_sync() function is deprecated, documentation suggests vte_terminal_spawn_async()
- With Gdk > 3.20 gdk_keyboard_grab() / gdk_keyboard_ungrab() are also deprecated, replaced by gdk_seat_grab() / gdk_seak_ungrab()

There is also warning about GtkStatusIcon (but we need to modify deeeply terminal/terminal-dropdown-window.c).
Comment 1 Igor editbugs 2018-03-09 15:24:58 CET
Hi Olivier, and thanks for the patches! I will review them.

As for GtkStatusIcon, GTK3 does not seem to provide any proper replacement for it. They suggest using notifications, but I cannot see how a notification can work the same way as a status icon, so I've decided to leave the code as is. Perhaps, I need to suppress these warnings as I've done in other places in the code.
However, when GTK4 is released, I might have to revisit the code or even drop the status icon support.
Comment 2 Git Bot editbugs 2018-03-09 15:59:08 CET
Olivier Duchateau referenced this bugreport in commit 386e42995d71149d05f232e95d175a853a2f0bf2

Fix gdk_keyboard_(un)grab deprecation warnings

https://git.xfce.org/apps/xfce4-terminal/commit?id=386e42995d71149d05f232e95d175a853a2f0bf2
Comment 3 Git Bot editbugs 2018-03-10 01:10:51 CET
Olivier Duchateau referenced this bugreport in commit 48106cb37a9d904428e4082166cd87a55aee04e5

Use async spawn method for VTE >= 0.48

https://git.xfce.org/apps/xfce4-terminal/commit?id=48106cb37a9d904428e4082166cd87a55aee04e5
Comment 4 Igor editbugs 2018-03-10 01:11:07 CET
Merged, thanks!
Comment 5 Igor editbugs 2018-03-19 14:30:00 CET
(In reply to Olivier Duchateau from comment #0)
> - With Gdk > 3.20 gdk_keyboard_grab() / gdk_keyboard_ungrab() are also
> deprecated, replaced by gdk_seat_grab() / gdk_seak_ungrab()
I had to revert this change as it has broken drop-down terminal hotkey: see bug #14289.
I'm going to just suppress these warnings as I have no idea why the new APIs work differently compared to the deprecated ones.

Bug #14249

Reported by:
Olivier Duchateau
Reported on: 2018-02-26
Last modified on: 2018-03-19

People

CC List:
0 users

Version

Version:
0.8.7.1

Attachments

Fix a couple of warnings (4.20 KB, patch)
2018-02-26 21:54 CET , Olivier Duchateau
no flags

Additional information