xfce-dialogs.c:477]: (warning) The expression 'strcmp(stock_id,"yes") != 0' is suspicious. It overlaps 'strcmp(stock_id,"gtk-yes") == 0'. Source code is if (stock_id != NULL && (strcmp (stock_id, "gtk-yes") == 0 || strcmp (stock_id, "yes")) == 0) Maybe better code if (stock_id != NULL && (strcmp (stock_id, "gtk-yes") == 0 || strcmp (stock_id, "yes") == 0))
This has been fixed in: https://git.xfce.org/xfce/libxfce4ui/commit/?id=e3c255de0b38be5eb92cfaf3ef7243b2c4817dc6 This bug's version says git, are you building from current git master or at least libxfce4ui-4.13.3?
I am building from fedora rawhide i.e. libxfce4ui-4.12.1 It looks like I used an out of date version. My apologies for the bug report.