! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Bug with selection when pressing both RMB and LMB together
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description delta.cxx 2018-01-21 14:45:37 CET
Bug with selection when pressing both RMB and LMB together: hold RMB on desktop and press LMB while holding RMB. You'll get file manager window. Close it and selection will follow your mouse while you're not holding the button.
Comment 1 Andre Miranda editbugs 2018-10-19 02:54:39 CEST
I can reproduce with xfdesktop 4.13.2, I just need to press both RMB and LMB at the same time.
The file manager is not opened anymore because gtk3 does not position the context menu under the cursor.
Comment 2 Theo Linkspfeifer editbugs 2019-03-29 17:55:49 CET
Created attachment 8366 
proposed patch

Same thing happens in Thunar also.

My proposed change for xfdesktop is to stop an ongoing drag/selection event if the middle or right mouse button is pressed. Furthermore, this fixes a visual glitch (selection rectangle not being removed after right-clicking on a desktop icon).
Comment 3 Git Bot editbugs 2019-03-30 19:31:20 CET
Theo Linkspfeifer referenced this bugreport in commit 57ac5cb30a1e01bd506799a088940ca2e0f13ca0

Stop ongoing drag/selection if middle/right mouse button is pressed (Bug #14180)

https://git.xfce.org/xfce/xfdesktop/commit?id=57ac5cb30a1e01bd506799a088940ca2e0f13ca0
Comment 4 Andre Miranda editbugs 2019-03-30 19:32:29 CET
Thanks for the patch, looks good to me.
Can you also send one for Thunar?

Bug #14180

Reported by:
delta.cxx
Reported on: 2018-01-21
Last modified on: 2019-03-30

People

Assignee:
Eric Koegel
CC List:
2 users

Version

Version:
4.13.3

Attachments

proposed patch (2.64 KB, patch)
2019-03-29 17:55 CET , Theo Linkspfeifer
no flags

Additional information