! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Sound doesn't increase over 100% using keyboard or mouse scroll
Status:
RESOLVED: MOVED
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description Nurlan Musayev 2018-01-07 08:32:31 CET
Created attachment 7525 
Fixed increasing volume. Added a checkbox in GUI. Added scaling for volume bar in notifications.

Steps to Reproduce:
 Keep pressing special media key to increase volume.

Actual results:
- Volume is stuck in 100%.

Expected results:
- Volume should increase until 150%

Build Date & Hardware:
Build 2017-12-07 on Arch Linux. 

Additional Information:
I tried to make some changes: 
1) Volume can be increased above 100% with keyboard and scrolling;
2) Added a checkbox in GUI to enable/disable this feature manually;
3) Also added scaling volume bar in notifications depending on the state of the checkbox.
Patch file is attached.
Comment 1 Or Schiro 2018-09-24 22:11:15 CEST
Dear all, 

I am adding myself to this list as I consider this a very useful feature and providing support for touchpad scroll and keyboard volume keys would be consistent with the experience on other desktop environments. 

Also adding a related discussion from the forums [1].

Yours

[1] https://forum.xfce.org/viewtopic.php?pid=49774#p49774
Comment 2 Anonymous 2019-01-09 14:20:06 CET
Please, solve this error as soon as possible, in my Debian XFCE I can not increase the volume to the maximum with the keys
Comment 3 Or Schiro 2019-01-09 14:47:44 CET
It's been a year now since Nurlan provided the patch. Is there any chance we can merge the patch timely?
Comment 4 Andrzej editbugs 2019-01-09 21:58:52 CET
For the record, I've implemented it this way on purpose, to prevent accidental increase of volume beyond 100%. Volumes above 100% are accessible via volume slider only. Whilst at >100% volume it is possible to use keyboard shortcuts to *decrease* the volume, though.

Maximum volume is somewhat arbitrarily set to 150% (afair). There is nothing special about this value other than the fact that higher volume range would make the sliders difficult to use precisely. Also, pulseaudio-mixer is using a similar maximum volume level (153%?).

If other devs have different preferences I'm fine with changing this behaviour. The above is to explain the reasons behind the current implementation.

The patch looks OK to me. Another option would be to simply allow the shortcuts in the whole range of volumes but make the maximum volume configurable with a default of 100%.
Comment 5 Or Schiro 2019-01-10 21:11:15 CET
> For the record, I've implemented it this way on purpose, to prevent accidental increase of volume beyond 100%. Volumes above 100% are accessible via volume slider only. Whilst at >100% volume it is possible to use keyboard shortcuts to *decrease* the volume, though.

I understand your reasoning. This reminds me of GNOME where (I think) you can only go beyond 100% with the volume keys on your keyboard if your holding Shift as well. 

Alternatively, I recall that in the old days of Unity, there was a checkbox in the volume settings. If you ticked that, it allowed you to go beyond 100%. That would prevent any accidental increases beyond 100% as well.
Comment 6 Git Bot editbugs 2020-05-23 00:38:32 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/-/issues/12.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #14148

Reported by:
Nurlan Musayev
Reported on: 2018-01-07
Last modified on: 2020-05-23

People

Assignee:
Andrzej
CC List:
2 users

Version

Attachments

Additional information