terminal-screen.c: In function 'terminal_screen_update_text_blink_mode': terminal-screen.c:1222:3: error: unknown type name 'VteTextBlinkMode'; did you mean 'VteCursorBlinkMode'? VteTextBlinkMode mode = VTE_TEXT_BLINK_ALWAYS; ^~~~~~~~~~~~~~~~ VteCursorBlinkMode terminal-screen.c:1222:32: error: 'VTE_TEXT_BLINK_ALWAYS' undeclared (first use in this function); did you mean 'TERMINAL_TEXT_BLINK_ALWAYS'? VteTextBlinkMode mode = VTE_TEXT_BLINK_ALWAYS; ^~~~~~~~~~~~~~~~~~~~~ TERMINAL_TEXT_BLINK_ALWAYS terminal-screen.c:1222:32: note: each undeclared identifier is reported only once for each function it appears in terminal-screen.c:1232:16: error: 'VTE_TEXT_BLINK_NEVER' undeclared (first use in this function); did you mean 'VTE_TEXT_BLINK_ALWAYS'? mode = VTE_TEXT_BLINK_NEVER; ^~~~~~~~~~~~~~~~~~~~ VTE_TEXT_BLINK_ALWAYS terminal-screen.c:1236:16: error: 'VTE_TEXT_BLINK_FOCUSED' undeclared (first use in this function); did you mean 'VTE_TEXT_BLINK_NEVER'? mode = VTE_TEXT_BLINK_FOCUSED; ^~~~~~~~~~~~~~~~~~~~~~ VTE_TEXT_BLINK_NEVER terminal-screen.c:1240:16: error: 'VTE_TEXT_BLINK_UNFOCUSED' undeclared (first use in this function); did you mean 'VTE_TEXT_BLINK_FOCUSED'? mode = VTE_TEXT_BLINK_UNFOCUSED; ^~~~~~~~~~~~~~~~~~~~~~~~ VTE_TEXT_BLINK_FOCUSED terminal-screen.c:1222:25: warning: variable 'mode' set but not used [-Wunused-but-set-variable] VteTextBlinkMode mode = VTE_TEXT_BLINK_ALWAYS; ^~~~ terminal-screen.c: In function 'terminal_screen_launch_child': terminal-screen.c:1745:7: warning: 'vte_terminal_spawn_sync' is deprecated [-Wdeprecated-declarations] --------------- Been getting this from most recent Git checkout. Compiling on Fedora 27 fails. Please fix if possible.
Igor referenced this bugreport in commit 6362e00819f728d1965493f27926dce26a45a69a Fix compilation with vte < 0.51.3 https://git.xfce.org/apps/xfce4-terminal/commit?id=6362e00819f728d1965493f27926dce26a45a69a
Sorry, my bad. :( Fixed now, thanks!
Igor, after make distclean im getting different compilation error too. make[3]: Entering directory '/home/avb/work/xfce4-terminal/terminal' CC xfce4_terminal-terminal-enum-types.o CC xfce4_terminal-terminal-marshal.o CC xfce4_terminal-main.o CC xfce4_terminal-terminal-app.o CC xfce4_terminal-terminal-encoding-action.o CC xfce4_terminal-terminal-gdbus.o CC xfce4_terminal-terminal-image-loader.o CC xfce4_terminal-terminal-options.o CC xfce4_terminal-terminal-preferences.o terminal-preferences.c: In function ‘terminal_preferences_class_init’: terminal-preferences.c:281:5: error: ‘TERMINAL_TYPE_TEXT_BLINK_MODE’ undeclared (first use in this function); did you mean ‘TERMINAL_TEXT_BLINK_NEVER’? TERMINAL_TYPE_TEXT_BLINK_MODE ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ TERMINAL_TEXT_BLINK_NEVER terminal-preferences.c:281:5: note: each undeclared identifier is reported only once for each function it appears in terminal-preferences.c:1149:26: warning: passing argument 4 of ‘g_param_spec_enum’ makes integer from pointer without a cast [-Wint-conversion] TERMINAL_TYPE_TEXT_BLINK_MODE, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/glib-2.0/glib-object.h:28:0, from /usr/include/glib-2.0/gio/gioenums.h:28, from /usr/include/glib-2.0/gio/giotypes.h:28, from /usr/include/glib-2.0/gio/gio.h:26, from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28, from /usr/include/gtk-3.0/gdk/gdk.h:32, from /usr/include/gtk-3.0/gtk/gtk.h:30, from ../terminal/terminal-enum-types.h:6, from terminal-preferences.c:35: /usr/include/glib-2.0/gobject/gparamspecs.h:1055:13: note: expected ‘GType {aka long unsigned int}’ but argument is of type ‘const GType * {aka const long unsigned int *}’ GParamSpec* g_param_spec_enum (const gchar *name, ^~~~~~~~~~~~~~~~~ Makefile:753: recipe for target 'xfce4_terminal-terminal-preferences.o' failed make[3]: *** [xfce4_terminal-terminal-preferences.o] Error 1 make[3]: Leaving directory '/home/avb/work/xfce4-terminal/terminal' Makefile:507: recipe for target 'all' failed make[2]: *** [all] Error 2 make[2]: Leaving directory '/home/avb/work/xfce4-terminal/terminal' Makefile:561: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/home/avb/work/xfce4-terminal' Makefile:451: recipe for target 'all' failed make: *** [all] Error 2 avb@ds:~/work/xfce4-terminal$
Alexander, TERMINAL_TYPE_TEXT_BLINK_MODE should be defined in terminal-enum-types.h as follows: #define TERMINAL_TYPE_TEXT_BLINK_MODE (terminal_text_blink_mode_get_type()) with the function implementation in terminal-enum-types.c. terminal-enum-types.h and .c are auto-generated. Are they generated for you after running `make distclean`, `./autogen.sh`, and `make`?
Im very sorry to bother. I forgot to run autogen :-/
Phew! :) I thought I was missing something.