! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Panel crashes when removing some plugins
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
General

Comments

Description Andre Miranda editbugs 2018-01-06 05:28:09 CET
On Workspace Switcher removal, panel crashes with the following message:
libxfce4panel:ERROR:xfce-panel-plugin.c:919:xfce_panel_plugin_finalize: assertion failed: (plugin->priv->menu_items == ((void *)0))
[1]    13393 abort (core dumped)  xfce4-panel

Whisker Menu and Weather also output this same error message, but the panel doesn't crash.
Comment 1 Simon Steinbeiss editbugs 2018-01-07 00:11:37 CET
All of those aforementioned plugins add a custom menu item to their right-click/context menu via xfce_panel_plugin_menu_insert_item.
https://git.xfce.org/xfce/xfce4-panel/tree/libxfce4panel/xfce-panel-plugin.c#n2190

There seems to be some problem with the order of destroying the menuitem and the menu.
Comment 2 Simon Steinbeiss editbugs 2018-01-07 00:31:50 CET
Also, my guess is that whisker and weather being external plugins just crash and get restarted (or you get the option to restart them) whereas the internal pager/workspaces plugin takes the panel down along with it.
Comment 3 Simon Steinbeiss editbugs 2018-05-29 00:12:15 CEST
Created attachment 7755 
Try to fix removing plugins

I attached a patch that hopefully fixes the crash. Not at all sure though why this behavior seems to have changed between Gtk+2 and 3.
Comment 4 Simon Steinbeiss editbugs 2018-05-29 00:13:05 CEST
*** Bug 14418 has been marked as a duplicate of this bug. ***
Comment 5 Andre Miranda editbugs 2018-05-29 00:49:54 CEST
Works well for me, no more crashes and no more error messages.
Thanks!
Comment 6 Git Bot editbugs 2018-06-05 01:04:38 CEST
Simon Steinbeiss referenced this bugreport in commit d614f388b0202ae55377b1058d90381b226f4deb

panel-plugin: Try to fix crashes when removing plugins (Bug #14144)

https://git.xfce.org/xfce/xfce4-panel/commit?id=d614f388b0202ae55377b1058d90381b226f4deb

Bug #14144

Reported by:
Andre Miranda
Reported on: 2018-01-06
Last modified on: 2018-06-13

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
4.13.1

Attachments

Try to fix removing plugins (1.14 KB, patch)
2018-05-29 00:12 CEST , Simon Steinbeiss
no flags

Additional information