! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Switch to GtkIconTheme
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Libxfce4panel

Comments

Description Olivier Duchateau 2017-12-27 07:35:05 CET
Created attachment 7511 
Switch to GtkIconTheme

In libxfce4panel/xfce-panel-image.c we still use GtkIconSource. Unfortunately all functions gtk_icon_source_... are deprecated since version 3.10. So I think we need to switch to GtKIconTheme. Patch fixes this issue.

> xfce-panel-image.c: In function 'xfce_panel_image_draw':
> xfce-panel-image.c:523:11: warning: 'gtk_icon_source_new' is deprecated [-Wdeprecated-declarations]
>           source = gtk_icon_source_new ();
>           ^~~~~~
> In file included from /usr/include/gtk-3.0/gtk/gtkstyleprovider.h:27:0,
>                 from /usr/include/gtk-3.0/gtk/gtkstylecontext.h:27,
>                 from /usr/include/gtk-3.0/gtk/gtkicontheme.h:27,
>                 from /usr/include/gtk-3.0/gtk/gtk.h:123,
>                 from xfce-panel-image.c:30:
> /usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:170:16: note: declared here
> GtkIconSource* gtk_icon_source_new                      (void);
>                           ^~~~~~~~~~~~~~~~~~~
> xfce-panel-image.c:524:11: warning: 'gtk_icon_source_set_pixbuf' is deprecated [-Wdeprecated-declarations]
>          gtk_icon_source_set_pixbuf (source, pixbuf);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~
>In file included from /usr/include/gtk-3.0/gtk/gtkstyleprovider.h:27:0,
>                 from /usr/include/gtk-3.0/gtk/gtkstylecontext.h:27,
>                 from /usr/include/gtk-3.0/gtk/gtkicontheme.h:27,
>                 from /usr/include/gtk-3.0/gtk/gtk.h:123,
>                 from xfce-panel-image.c:30:
> /usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:183:16: note: declared here
>void           gtk_icon_source_set_pixbuf               (GtkIconSource       *source,
>                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
> xfce-panel-image.c:525:11: warning: 'gtk_render_icon_pixbuf' is deprecated: Use 'gtk_icon_theme_load_icon' instead [-Wdeprecated-declarations]
>           rendered = gtk_render_icon_pixbuf (context, source, -1);
>           ^~~~~~~~
> In file included from /usr/include/gtk-3.0/gtk/gtk.h:177:0,
>                 from xfce-panel-image.c:30:
> /usr/include/gtk-3.0/gtk/gtkrender.h:146:13: note: declared here
> GdkPixbuf * gtk_render_icon_pixbuf (GtkStyleContext     *context,
>                     ^~~~~~~~~~~~~~~~~~~~~~
> xfce-panel-image.c:526:11: warning: 'gtk_icon_source_free' is deprecated [-Wdeprecated-declarations]
>           gtk_icon_source_free (source);
>           ^~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/gtk-3.0/gtk/gtkstyleprovider.h:27:0,
>                 from /usr/include/gtk-3.0/gtk/gtkstylecontext.h:27,
>                 from /usr/include/gtk-3.0/gtk/gtkicontheme.h:27,
>                 from /usr/include/gtk-3.0/gtk/gtk.h:123,
>                 from xfce-panel-image.c:30:
> /usr/include/gtk-3.0/gtk/deprecated/gtkiconfactory.h:174:16: note: declared here
>void           gtk_icon_source_free                     (GtkIconSource       *source);
>                  ^~~~~~~~~~~~~~~~~~~~
Comment 1 Git Bot editbugs 2018-01-02 21:22:00 CET
Olivier Duchateau referenced this bugreport in commit 3e87296e7229f3e100b11ba29fb1c870a26fc9db

Switch to GtkIconTheme (Bug #14125)

https://git.xfce.org/xfce/xfce4-panel/commit?id=3e87296e7229f3e100b11ba29fb1c870a26fc9db

Bug #14125

Reported by:
Olivier Duchateau
Reported on: 2017-12-27
Last modified on: 2018-01-02

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
4.13.2

Attachments

Switch to GtkIconTheme (1.68 KB, patch)
2017-12-27 07:35 CET , Olivier Duchateau
no flags

Additional information