! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Desktop menu is displayed once in two when Icon Type pref is None
Status:
RESOLVED: DUPLICATE
Product:
Xfdesktop
Component:
General

Comments

Description Skunnyk editbugs 2017-12-16 19:22:55 CET
With xfdesktop git master, when I right click on the desktop without icons ("Icon type: None" in xfdesktop-settings preferences), the  menu popup once in two.

In debug mode :

When it works :
DBG[xfce-desktop.c:1198] xfce_desktop_button_press_event(): entering
DBG[xfce-desktop.c:1766] xfce_desktop_popup_root_menu(): entering
DBG[xfce-desktop.c:1725] xfce_desktop_do_menu_popup(): entering
DBG[menu.c:72] menu_populate(): show desktop menu icons TRUE

When it does not works:
DBG[xfce-desktop.c:1198] xfce_desktop_button_press_event(): entering
DBG[xfce-desktop.c:1198] xfce_desktop_button_press_event(): entering
DBG[xfce-desktop.c:1235] xfce_desktop_button_release_event(): entering
DBG[xfce-desktop.c:1235] xfce_desktop_button_release_event(): entering
Comment 1 Skunnyk editbugs 2017-12-16 21:11:28 CET
The grab is not correct inside xfce_desktop_button_press_event().

Since 3907aba542aee92630bf1970071fdc20be5f6ad3 the xfce_desktop_popup_root_menu is inside if(!gtk_widget_has_grab(w)), but once in two, it does not enter in the if…

Before 3907aba542aee92630bf1970071fdc20be5f6ad3 it works "by mistake" because even if the if condition in not met, it runs xfce_desktop_popup_root_menu nonetheless.

So, why the grab is not correct ? :(
Comment 2 Skunnyk editbugs 2018-09-18 19:09:39 CEST
Fixed by #14415

*** This bug has been marked as a duplicate of bug 14415 ***

Bug #14091

Reported by:
Skunnyk
Reported on: 2017-12-16
Last modified on: 2018-09-18

People

Assignee:
Eric Koegel
CC List:
0 users

Version

Version:
4.13.1

Attachments

Additional information