! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
make distcheck is broken
Status:
RESOLVED: FIXED
Product:
Libxfce4ui
Component:
General

Comments

Description Skunnyk editbugs 2017-11-27 14:15:05 CET
We want to release 4.13.4, and make distcheck is broken on libxfce4ui when "vala" is present on the system due to the introduction of vala binding generation in commits d2be189ba145700cdba00b48c4e848dcd18d9326 and following.

By reading https://cgit.freedesktop.org/accountsservice/commit/?id=17af4612e877c3a5c6bff67064d648f0eb2ea0cc , https://wiki.gnome.org/Projects/Vala/FAQ#Is_having_a_local_copy_of_a_.vapi_in_my_project_good_practice.3F and https://wiki.gnome.org/Projects/Vala/UpstreamGuide#Autotools_Integration


So I propose to add --enable-vala=no in DISTCHECK_CONFIGURE_FLAGS (like --disable-gladeui).
Patch incoming (with other small fixes for distcheck)

The other solution is to remove the vala thing from the code.

Same bug will be open for xfce4-panel.
Comment 1 Skunnyk editbugs 2017-11-27 18:48:18 CET
Created attachment 7455 
Fix make distcheck
Comment 2 Git Bot editbugs 2017-11-30 18:59:49 CET
Romain B referenced this bugreport in commit c029290d91f2fe37dfdaacdee79c48c120b135ba

Fix make distcheck

https://git.xfce.org/xfce/libxfce4ui/commit?id=c029290d91f2fe37dfdaacdee79c48c120b135ba
Comment 3 Simon Steinbeiss editbugs 2017-12-11 00:07:38 CET
Shouldn't this be marked as fixed or at least as assigned?

Bug #14039

Reported by:
Skunnyk
Reported on: 2017-11-27
Last modified on: 2017-12-11

People

Assignee:
Eric Koegel
CC List:
3 users

Version

Attachments

Fix make distcheck (1.69 KB, patch)
2017-11-27 18:48 CET , Skunnyk
no flags

Additional information