! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-pulseaudio-plugin incorrectly stretches to "number of rows" after updat...
Status:
RESOLVED: FIXED
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description Michal Varga 2017-11-12 17:23:56 CET
Created attachment 7430 
Plugin size bug in deskbar panel mode

Using Arch Linux, after updating xfce4-pulseaudio-plugin from 0.2.5 to 0.3.2 (previous stable version to the latest stable version, as of today), the panel plugin size is calculated completely wrong in both horizontal and deskbar mode. 

Previously, the plugin size ignored the "number of rows" panel value and remained at the size of a single item, thus being able to stack with other similar non-stretching items (launchers, some plugins, etc.) As of 0.3.2, the entire plugin stretches to the total row size, but even there the horizontal/vertical value seems to be mistakenly reversed.

Screenshots illustrating both horizontal and deskbar modes are attached. It looks like the plugin is trying to hijack the entire available size of the panel (though each time in the wrong orientation), while previously the plugin icon size simply stayed at the size of a single item, as illustrated by the other icons in the screenshots.
Comment 1 Michal Varga 2017-11-12 17:25:10 CET
Created attachment 7431 
Plugin size bug in horizontal panel mode

Second screenshot attached.
Comment 2 Harald Judt editbugs 2017-11-14 13:35:07 CET
Created attachment 7436 
fix-size-calculation-caused.patch

Try this patch which fixes the issue for me.
Comment 3 Michal Varga 2017-11-14 17:30:03 CET
Created attachment 7437 
Plugin size bug fixed

(In reply to Harald Judt from comment #2)
> Created attachment 7436 
> fix-size-calculation-caused.patch
> 
> Try this patch which fixes the issue for me.

Thank you, confirming that after applying the patch, plugin again behaves as before 0.3.2

Screenshot attached.

(The somewhat weirdly offset tooltip is not an issue, as all panel plugins show tooltips this way.)
Comment 4 Git Bot editbugs 2017-11-22 04:22:30 CET
Harald Judt referenced this bugreport in commit 2c8c8a39e2c604337f9e5b5e11ffbce26ea24d3a

Fix size calculation caused by 7c2e79ae34 (bug #13998)

https://git.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/commit?id=2c8c8a39e2c604337f9e5b5e11ffbce26ea24d3a
Comment 5 Sean Davis editbugs 2017-11-22 04:22:59 CET
Thanks for the patch!
Comment 6 Sean Davis editbugs 2017-11-22 04:24:50 CET
*** Bug 14011 has been marked as a duplicate of this bug. ***

Bug #13998

Reported by:
Michal Varga
Reported on: 2017-11-12
Last modified on: 2017-11-22
Duplicates (1):
  • 14011 Deskbar orientation is not accounted for

People

Assignee:
Andrzej
CC List:
4 users

Version

Version:
unspecified

Attachments

Plugin size bug in deskbar panel mode (49.23 KB, image/png)
2017-11-12 17:23 CET , Michal Varga
no flags
Plugin size bug in horizontal panel mode (46.96 KB, image/png)
2017-11-12 17:25 CET , Michal Varga
no flags
fix-size-calculation-caused.patch (1.11 KB, patch)
2017-11-14 13:35 CET , Harald Judt
no flags
Plugin size bug fixed (16.10 KB, image/png)
2017-11-14 17:30 CET , Michal Varga
no flags

Additional information