Created attachment 7425 Patch If multiple DE are installed (in my case XFCE and KDE) xfce4-notifyd is not started most of the times. Reason for this is that dbus name 'org.freedesktop.Notifications' is not unique and it is not predictable which one is started. With the new configure option packagers can decide how to start xfce4-notifyd dbus/autostart. Default is as is: Start by dbus. A nice side effect of this change is that if multiple notification daemons are installed using autostart, user can decide which one to use. I know it was suggested in https://bugzilla.xfce.org/show_bug.cgi?id=7950 but times have changed - xfce4-notifiyd is running all the time since d87a4a93b2ec4ab094f5a35ae818395f750f2891.
If I understand your patch correctly the default behaviour does change with it. While it gets started via dbus by default, you disabled that by default and it has to be enabled with the '--enable-dbus-start-daemon' explicitely. I would keep it the other way round, because the current behaviour is what distro maintainers are currently used to.
I get a bit confused now :) The patch keeps current behavior (start by dbus) if the option --enable-dbus-start-daemon is not set. Intention was to avoid unwanted surprises for packagers. Only if --disable-dbus-start-daemon is set explicitly, xfce4-notifyd is started by autostart. What is your suggestion?
Right, sorry, I misread the patch. I guess you suggest this for systems without systemd? Cause with systemd it's fairly easy to set up autostart via the included service file.
Andreas Müller referenced this bugreport in commit 72334c07ae266dbb07adb73b247e944fa8fa13b3 Add configure option to use autostart instead of dbus (Bug #13989) https://git.xfce.org/apps/xfce4-notifyd/commit?id=72334c07ae266dbb07adb73b247e944fa8fa13b3
Patch pushed to master.
Created attachment 7488 Fix tarball patch
Sorry for causing further effords but xfce4-notifyd/xfce4-notifyd.desktop.in did not make it into the tarball
*** Bug 14084 has been marked as a duplicate of this bug. ***
Andreas Müller referenced this bugreport in commit 8772d89db2f1df9aff7f26ae6b5b07f0511e1511 Ensure xfce4-notifyd.desktop.in goes into the tarball (Bug #13989) https://git.xfce.org/apps/xfce4-notifyd/commit?id=8772d89db2f1df9aff7f26ae6b5b07f0511e1511
No worries, not that many efforts caused (especially since you provided the additional patch yourself ;))