! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Quick port to Thunarx-3
Status:
RESOLVED: FIXED
Product:
Thunar-media-tags-plugin
Component:
General

Comments

Description Ali Akcaagac 2017-10-31 16:42:54 CET
Created attachment 7404 
thunar-media-tags.patch

Please find attached a quick port to Thunarx-3. No further testing was done with this because I needed the plugins to be buildable again.
Comment 1 Ali Akcaagac 2017-10-31 16:48:44 CET
Created attachment 7406 
thunar-media-tags.patch including configure adjustments
Comment 2 Ali Akcaagac 2017-10-31 18:29:56 CET
Created attachment 7408 
thunar-media-tags-plugin.patch against GIT
Comment 3 Andre Miranda editbugs 2017-11-01 04:34:37 CET
Created attachment 7409 
gtk3 and thunarx-3 port

Are you sure that just bump thunax version in configure.ac.in is enough to make this plugin work?
Anyway, here goes a WIP patch.
Comment 4 Ali Akcaagac 2017-11-01 10:59:07 CET
No! But I was able to get the stuff compiled again... I commented on the thunar-volume report on my motivations for this:

https://bugzilla.xfce.org/show_bug.cgi?id=13967#c4

But thanks for the patch. Would it be possible for you to commit the changes to git.xfce.org master ?

Sooner or later the plugins need to be ported anyways, so better have them in git master...
Comment 5 Andre Miranda editbugs 2017-11-02 03:41:23 CET
It compiles but very likely fails at runtime, actually it's not even loaded by thunar-git since it looks for extensions in <prefix>/lib/thunarx-3.

Regarding the WIP patches, I'll merge them this weekend or next week, they are off the tree because I wanted some feedback before merging. Also notice that these patches are incompatible with thunar-git, since the API changes are also in a personal repository. Please wait a few days and those problems will be gone :)
Comment 6 Andre Miranda editbugs 2017-11-03 00:10:36 CET
I had some free time today, so I merged everything (thunarx-3 and media-tags-plugins changes) to master, please test and report any bug found.
Comment 7 Ali Akcaagac 2017-11-05 10:21:13 CET
Getting this error after compiling from GIT.

tag-renamer.c: At top level:
tag-renamer.c:896:34: error: unknown type name 'ThunarxMenuItem'; did you mean 'ThunarxRenamer'?
 tag_renamer_edit_tags_activated (ThunarxMenuItem *item,
                                  ^~~~~~~~~~~~~~~
                                  ThunarxRenamer
make[2]: *** [Makefile:545: thunar_media_tags_plugin_la-tag-renamer.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
Comment 8 Ali Akcaagac 2017-11-05 10:29:17 CET
This issue also spwans in other areas of tag-renamer.c
Comment 9 Ali Akcaagac 2017-11-05 14:29:35 CET
Probably installs into /lib/thunarx-2 like thunar-archive-manager
Comment 10 Ali Akcaagac 2017-11-05 17:23:43 CET
Please ignore my feedback before. There was an issue with one of our scripts causing the issue by overwriting the new master.tar.bz2 download with an old version. We fixed that issue on our side.

Your changes were all correct and working. Also correct installation.

Bug #13968

Reported by:
Ali Akcaagac
Reported on: 2017-10-31
Last modified on: 2017-11-05

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
unspecified

Attachments

thunar-media-tags.patch (620 bytes, patch)
2017-10-31 16:42 CET , Ali Akcaagac
no flags
thunar-media-tags.patch including configure adjustments (3.72 KB, patch)
2017-10-31 16:48 CET , Ali Akcaagac
no flags
thunar-media-tags-plugin.patch against GIT (634 bytes, patch)
2017-10-31 18:29 CET , Ali Akcaagac
no flags
gtk3 and thunarx-3 port (10.04 KB, patch)
2017-11-01 04:34 CET , Andre Miranda
no flags

Additional information