! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
4.13 Launcher Icons and Arrow Buttons
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Drew Henry 2017-10-31 05:56:07 CET
I recently decided to install xfce4-panel-git and have since noticed a few issues:

1. Some launcher icons are not displaying: osbuddy, supertux, astromenace, lincity, and a custom application whose icon is stored in ~/.local/share/icons/custom/apps/64. A few other icons posed an issue on install but were fixed by deleting and recreating the launcher (tor-browser-en and spyder). All are displaying fine in "Add New Item" (but then no icon shows up on the panel).

2. Arrow buttons are not appearing for launchers that span the entire panel (east/west buttons for launchers on a vertical panel and north/west buttons for launchers on a horizontal panel). In 4.12 the icon would shrink and the arrow button would be placed next to it but in 4.13 the icon stays its original size leaving no room for the arrow.

3. There is no text on the Confirm button in the "Are you sure you want to remove x?" launcher item removal dialog box.

4. Launcher icons are awfully large in 4.13. In 4.12 I still had room for a couple more launchers in my vertical panel but now it is completely full.
Comment 1 Simon Steinbeiss editbugs 2017-11-11 00:38:42 CET
1. Should be addressed https://git.xfce.org/xfce/xfce4-panel/commit/?id=6345387b168fd25240b1d025e277fb0ea4c7131e

2. Interesting, will have to investigate.

3. This text comes from xfce-dialogs.c in libxfce4ui, so it's definitely not a panel bug. Afaict it has been fixed a longer time ago in libxfce4ui, so I'm not sure why you're seeing this problem. Which version are you using?

4. This is very likely a theming thing, at least I can't confirm with Greybird. A screenshot may help.
Comment 2 Drew Henry 2017-11-12 02:38:19 CET
1. After updating, astromenace and osbuddy are showing icons but lincity, linthesia, and supertux still are not. After some investigation I think I have found the issue: applications that list the icon name with a file extension but without an absolute path name. In the desktop files, astromenace lists the icon as /usr/share/pixmaps/astromenace.png while supertux lists it as supertux.png.

I also came across another icon issue while investigating this: applications whose icons are stored in /usr/share/pixmaps and that use an absolute path in their desktop file always display as the same size regardless of the row/column size of the panel which will be whatever size they were when added. So if I create a panel with a row size of 16px, add an astromenace launcher, and then increase the row size to 100px, the astromenace icon will remain ~16x16px in size. You can see this in the attached image with the osbuddy icon (the last icon below transmission).

2. See the images attached. The L3afpad icon (below Opera/Firefox) should have an arrow to the east.

3. I was using libxfce4ui 4.12 but after installing libxfce4ui-git (from the Arch Linux AUR) and restarting the issue hasn't gone away.

4. This was more of a suggestion than a bug.
Comment 3 Drew Henry 2017-11-12 02:39:37 CET
Created attachment 7428 
Panel Screenshot (4.12)
Comment 4 Drew Henry 2017-11-12 02:41:27 CET
Created attachment 7429 
Panel Screenshot (4.13)
Comment 5 Drew Henry 2017-11-12 03:02:27 CET
1. Update: It appears that most of the applications in question have since removed the file extension from the icon name, the changes just haven't made it to Arch yet (strange for lincity since the change was made in 2013).
Comment 6 Git Bot editbugs 2018-01-03 01:04:47 CET
Simon Steinbeiss referenced this bugreport in commit cb568546debf9e3c44350356799f7d7fbc781fc3

launcher: Fix empty button in remove launcher dialog (Bug #13962)

https://git.xfce.org/xfce/xfce4-panel/commit?id=cb568546debf9e3c44350356799f7d7fbc781fc3
Comment 7 Simon Steinbeiss editbugs 2018-01-03 01:06:03 CET
Ad 3) fixed in the commit above.
Comment 8 Simon Steinbeiss editbugs 2018-01-03 22:27:30 CET
Ad 1) Fixed the resizing of pixbufs when the panel size changes (https://bugzilla.xfce.org/show_bug.cgi?id=14138)
Comment 9 Simon Steinbeiss editbugs 2018-05-01 08:58:58 CEST
@drew henry: Could you check again what's left to be fixed for this report? I'm tempted to close it, it's really multiple reports and having to read the whole history again just to get the status is quite painful and a waste of time. So if something is still open with respect to launchers and 4.13, please open a new report and just copy-paste the relevant parts from this report.
Comment 10 Drew Henry 2018-05-01 23:16:40 CEST
2 still needs to be fixed which is the arrow button not showing for launchers that launch multiple applications. Per your request I will open up a new report.
Comment 11 Simon Steinbeiss editbugs 2018-05-02 13:49:41 CEST
Thanks!

Bug #13962

Reported by:
Drew Henry
Reported on: 2017-10-31
Last modified on: 2018-05-02

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Version:
4.13.1

Attachments

Panel Screenshot (4.12) (76.92 KB, image/png)
2017-11-12 02:39 CET , Drew Henry
no flags
Panel Screenshot (4.13) (74.27 KB, image/png)
2017-11-12 02:41 CET , Drew Henry
no flags

Additional information