! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Fix flag in g_bus_watch_name_on_connection() method
Status:
RESOLVED: FIXED
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description Olivier Duchateau 2017-10-29 20:09:42 CET
Created attachment 7398 
Fix flag in g_bus_watch_name_on_connection

With the latest release (0.3.2), I think there's a typo in panel-plugin/pulseaudio-mpris-player.c for g_bus_watch_name_on_connection() method. Documentation [1] says, the third parameter must be GBusNameWatcherFlags enum flag, but currently it's GBusNameOwnerFlags. When we build this plugin, a warning displays:

pulseaudio-mpris-player.c:542:45: warning: implicit conversion from enumeration
type 'GBusNameOwnerFlags' to different enumeration type 'GBusNameWatcherFlags' [
-Wenum-conversion]
                                            G_BUS_NAME_OWNER_FLAGS_REPLACE,
                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Patch fixes this issue.

[1] https://developer.gnome.org/gio/stable/gio-Watching-Bus-Names.html#g-bus-watch-name-on-connection
Comment 1 Git Bot editbugs 2017-11-22 04:27:48 CET
Olivier Duchateau referenced this bugreport in commit 95c21c35bd244a3b1cdec14b884582b12fde2aa8

Fix flag in g_bus_watch_name_on_connection() method (bug #13961)

https://git.xfce.org/panel-plugins/xfce4-pulseaudio-plugin/commit?id=95c21c35bd244a3b1cdec14b884582b12fde2aa8
Comment 2 Sean Davis editbugs 2017-11-22 04:28:16 CET
Great catch, thanks for the patch!

Bug #13961

Reported by:
Olivier Duchateau
Reported on: 2017-10-29
Last modified on: 2017-11-22

People

Assignee:
Andrzej
CC List:
1 user

Version

Version:
unspecified

Attachments

Fix flag in g_bus_watch_name_on_connection (1.14 KB, patch)
2017-10-29 20:09 CET , Olivier Duchateau
no flags

Additional information