! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Adapt power manager for desktop machines
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-power-manager
Component:
General

Comments

Description Massimo Burcheri 2017-10-29 13:14:00 CET
Using xfce-extra/xfce4-power-manager-1.6.0-r1 on Gentoo.
This is primarily made for mobile systems showing the battery state. However the display power management is another main job.
Using the power-manager on battery-less desktop systems for display power management only and for quick brightness setting, it is annoying to have a missing battery symbol.

There are 2 modes using the power manager:
1. is as panel item
2. is as notification in the notification panel item.

Both have some pro and cons:

1. Panel item:
+ Quick brightness change by scroll wheel on the icon.
- Taking too much space with that error text and icon:   [?] (0:00,0%)

2. Notification icon
+ No error text like the panel item, but still a "Missing battery" symbol
- Scroll wheel not working

Please adapt the application for battery less systems:
Make the panel item configurable to show battery status or not. If not, just show some common display, power or brightness symbol for having the scroll wheel function, and no error text.

(btw. with a usual 105 key-board without special key I see no way to change the display brightness if not configuring some custom shortcut for that)
Comment 1 Massimo Burcheri 2017-10-29 13:17:27 CET
Some additional comment about mode 2. Notification icon, there is some workaround for using the scroll wheel for brightness: Right click, waiting 2 seconds, scrolling on the appearing widget. But this is not very intuitive using the right click and slow with that 2 seconds delay.
Comment 2 Simon Steinbeiss editbugs 2017-10-29 20:46:04 CET
Hi,
so hiding the label when the device state is unknown (which is what should happen on a desktop system, at least as far as I can tell without having one) has been tackled recently, also see:
https://bugzilla.xfce.org/show_bug.cgi?id=12851

Regarding which icon is shown: this is entirely determined by UPower (so not xfce4-power-manager). Could you attach the output of
upower -d
to this bugreport? This output also includes the icon name.
Thanks!
Comment 3 Massimo Burcheri 2017-10-30 09:27:16 CET
Thanks. As for the panel item, it is not only the wrong icon but also the long (0:00,0%) percentage that is taking place.

# upower -d
Device: /org/freedesktop/UPower/devices/DisplayDevice
  power supply:         no
  updated:              So 29 Okt 2017 14:01:29 CET (69839 seconds ago)
  has history:          no
  has statistics:       no
  unknown
    warning-level:       none
    icon-name:          'battery-missing-symbolic'

Daemon:
  daemon-version:  0.99.6
  on-battery:      no
  lid-is-closed:   no
  lid-is-present:  no
  critical-action: PowerOff
Comment 4 Simon Steinbeiss editbugs 2017-11-02 00:41:39 CET
Well the percentage is 0, as you don't have a battery. And it that respect the "battery-missing" icon is also not 100% wrong :)

I would have expected a different icon name, but to be honest I don't even have a desktop pc available to test this with. I'll ask around.
Comment 5 Simon Steinbeiss editbugs 2017-11-19 22:05:13 CET
I have a patch that tries to fix the icon for desktop systems, but as I don't have a desktop around for testing it's a best effort/guess.

So please give it some testing:
https://git.xfce.org/users/ochosi/xfce4-power-manager/log/?h=bug-13959

The icon shown should be "ac-adapter-symbolic" (which in "Adwaita" is a battery with a flash, so don't be irritated about that...)
Comment 6 Git Bot editbugs 2017-11-19 23:26:10 CET
Simon Steinbeiss referenced this bugreport in commit 560a960e663e43f319e703fb9c8e394829066a42

panel-plugin: Set ac-adapter icon for desktop systems (Bug #13959)

https://git.xfce.org/xfce/xfce4-power-manager/commit?id=560a960e663e43f319e703fb9c8e394829066a42
Comment 7 Simon Steinbeiss editbugs 2017-11-19 23:29:22 CET
The branch linked to above has meanwhile seen some testing on desktop systems and after some iterations the problem should be fixed now.

So on desktop systems I would expect an "ac-adapter" (systray) or "ac-adapter-symbolic" icon to show up instead of the battery-missing one.

Regarding the percentage and remaining time I would suggest that for now you just hide that in the panel plugin's preferences dialog (I've recently added one for easy access to this option). I would prefer to not complicate the current code for automatically showing/hiding the label under certain conditions.
Comment 8 Simon Steinbeiss editbugs 2020-05-27 01:26:13 CEST
I'll consider this fixed for now as there are no more open requests.

Bug #13959

Reported by:
Massimo Burcheri
Reported on: 2017-10-29
Last modified on: 2020-05-27

People

Assignee:
Ali Abdallah
CC List:
3 users

Version

Attachments

Additional information