! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Bar style inconsistent with other plugins
Status:
RESOLVED: FIXED
Product:
Xfce4-genmon-plugin
Component:
General

Comments

Description fizulg 2017-10-28 20:09:00 CEST
Created attachment 7395 
Screenshot of systemload, netload and genmod bars, in both adwaita and arc-darker themes

As seen in the screenshot, the bar style (two on the right) is inconsistent with the bars in the systemload (left) and netload(middle) plugins.
Is it wider and starts from the top instead of the bottom.

Additionally there is a visible gap at the top and bottom, even when set to 100. This is especially noticable in dark themes, but affects all themes i tested, including xfce provided ones.

plugin version: 4.0.0
Comment 1 ToZ editbugs 2017-10-29 03:09:27 CET
Created attachment 7396 
Image

Interesting. I fixed the bar direction issue in this commit: https://git.xfce.org/panel-plugins/xfce4-genmon-plugin/commit/panel-plugin?id=a41e75b468abb9ae80a1d4207af7e37338e59144 but it doesn't seem to have made it into 4.0.0.

The gaps have been fixed since the last release.

I have also enhanced CSS styling (https://git.xfce.org/panel-plugins/xfce4-genmon-plugin/tree/CSS%20Styling.txt) but this still hasn't been released. With this styling, it is easier to do something like this:

.genmon_progressbar trough { min-height: 2px; min-width: 2px; }
.genmon_progressbar progress { min-height: 2px; min-width: 2px; }
.genmon_progressbar { margin: 2px; }

to get a similar styling with say the netload plugin with the Adwiata theme (see attached image).

Perhaps its time to do another release.
Comment 2 ToZ editbugs 2017-10-30 17:34:31 CET
I have released version 4.0.1. Please give that version a try with the css above.
Comment 3 fizulg 2017-10-30 21:00:23 CET
Created attachment 7401 
Screenshot of systemload, netload and improved genmon bars, in modified arc-darker theme

Yes, that works perfectly, even with arc.

Thanks!
Comment 4 ToZ editbugs 2017-10-30 23:25:52 CET
Closing report.

Bug #13957

Reported by:
fizulg
Reported on: 2017-10-28
Last modified on: 2017-10-30

People

Assignee:
Florian Rivoal
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information