! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Updating a notification with image-data, icon_data and app_icon yields incons...
Status:
RESOLVED: FIXED
Product:
Xfce4-notifyd
Component:
general

Comments

Description Simon Steinbeiss editbugs 2017-10-26 01:53:58 CEST
Created attachment 7385 
Fix icon_data being only fallback

Currently xfce4-notifyd yields strange and inconsistent results when updating a notification in various ways.
This is due to the insufficient handling of icon_data as a fallback-only option.

The attached patch fixes the behavior of the (also attached) reproducer for me.
Comment 1 Simon Steinbeiss editbugs 2017-10-26 01:55:13 CEST
Created attachment 7386 
Reproducer of the problem (icons are not updated)
Comment 2 Christian Hesse 2017-10-26 11:09:06 CEST
Works for me. Thanks!
Comment 3 Git Bot editbugs 2017-10-26 23:33:10 CEST
Simon Steinbeiss referenced this bugreport in commit c30e5559b01f407fd171c7ed60865e41a10404b6

Treat icon_data only as pen-ultimate fallback option (Bug #13950)

https://git.xfce.org/apps/xfce4-notifyd/commit?id=c30e5559b01f407fd171c7ed60865e41a10404b6
Comment 4 Simon Steinbeiss editbugs 2017-10-26 23:46:31 CEST
Thanks for reporting, providing the reproducer and testing!

Bug #13950

Reported by:
Simon Steinbeiss
Reported on: 2017-10-26
Last modified on: 2017-10-26

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

Fix icon_data being only fallback (4.74 KB, patch)
2017-10-26 01:53 CEST , Simon Steinbeiss
ochosi : review+
Reproducer of the problem (icons are not updated) (63.63 KB, text/x-csrc)
2017-10-26 01:55 CEST , Simon Steinbeiss
no flags

Additional information