! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
When Glade support is disabled in libxfce4ui, xinitrc still sets GLADE_*_PATH...
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Marcos Mello 2017-10-22 18:23:50 CEST
GLADE_CATALOG_PATH, GLADE_MODULE_PATH and GLADE_PIXMAP_PATH are set to useless value ":".

https://git.xfce.org/xfce/xfce4-session/tree/configure.ac.in#n204
https://git.xfce.org/xfce/xfce4-session/tree/scripts/xinitrc.in.in#n53

Possible solution (scripts/xinitrc.in.in):

if test -n "@XFCE_GLADE_CATALOG_PATH@" ; then
  GLADE_CATALOG_PATH="$GLADE_CATALOG_PATH:@XFCE_GLADE_CATALOG_PATH@"
  export GLADE_CATALOG_PATH
fi
if test -n "@XFCE_GLADE_PIXMAP_PATH@" ; then
  GLADE_PIXMAP_PATH="$GLADE_PIXMAP_PATH:@XFCE_GLADE_PIXMAP_PATH@"
  export GLADE_PIXMAP_PATH
fi
if test -n "@XFCE_GLADE_MODULE_PATH@" ; then
  GLADE_MODULE_PATH="$GLADE_MODULE_PATH:@XFCE_GLADE_MODULE_PATH@"
  export GLADE_MODULE_PATH
fi

BTW, gladeui2 paths should be used with the move to GTK+ 3, no?

Or drop these variables completely as per https://bugzilla.xfce.org/show_bug.cgi?id=9087 ?
Comment 1 Skunnyk editbugs 2017-12-17 23:24:46 CET
You are right, it still uses variables from libxfce4ui-1 ! And theses variables are empty if libxfce4ui is compiled without --enable-gladeui.
 
But after reading the old bug #9087, I'm not sure theses variables are usefull anymore…
Comment 2 Simon Steinbeiss editbugs 2017-12-17 23:52:28 CET
As far as I can see at least two of these specific env vars seem to be dead (and I don't suppose the pixmap path is useful for us at all, as we use named icons only in the glade files afaict) since Glade 3.10, quoting from its release message:

"WARNING: Both environment variables GLADE_CATALOG_PATH and GLADE_MODULE_PATH had been renamed
GLADE_CATALOG_SEARCH_PATH and GLADE_MODULE_SEARCH_PATH respectively because they conflict with 3.8.
This was a necessary API break to allow user catalogs and modules be parallel installable."
(https://mail.gnome.org/archives/gtk-devel-list/2011-October/msg00031.html)

So I (unless I've overlooked something) would be in favor of dropping the env vars completely or using the old ones for gtk2 and the new ones for gtk3, if that's easily doable.
Comment 3 Skunnyk editbugs 2017-12-18 22:29:37 CET
I +1 the removal of theses variables from the xinitrc, also from libxfce4ui-1.pc / libxfce4ui-2.pc (https://git.xfce.org/xfce/libxfce4ui/tree/libxfce4ui/libxfce4ui-2.pc.in).
Comment 4 Skunnyk editbugs 2018-01-03 18:11:15 CET
Created attachment 7518 
Remove now useless XFCE_GLADE_*_PATH variables
Comment 5 Marcos Mello 2018-05-01 13:52:20 CEST
Ping?
Comment 6 Git Bot editbugs 2018-09-23 19:43:56 CEST
Romain B referenced this bugreport in commit e8637503ca7a8641164b6cff75941647cf603774

Remove useless glade_*dir variables from libxfce4ui-{1,2}.pc

https://git.xfce.org/xfce/libxfce4ui/commit?id=e8637503ca7a8641164b6cff75941647cf603774
Comment 7 Marcos Mello 2018-11-03 11:46:34 CET
The variables are gone from libxfce4ui. Please apply Skunnyk's patch!
Comment 8 Git Bot editbugs 2018-11-12 23:52:16 CET
Romain B referenced this bugreport in commit 86a1b709facaec527dacdd0b4421b9a25128b2d2

Remove now useless XFCE_GLADE_*_PATH variables (Bug #13945)

https://git.xfce.org/xfce/xfce4-session/commit?id=86a1b709facaec527dacdd0b4421b9a25128b2d2

Bug #13945

Reported by:
Marcos Mello
Reported on: 2017-10-22
Last modified on: 2018-11-12

People

Assignee:
Skunnyk
CC List:
4 users

Version

Version:
4.13.0

Attachments

Additional information