GNOME Shell with Wayland: 1. Click anywhere on the application menu (the File Edit... at the top of the window). 2. Close it by any means (click elsewhere, press Esc, or actually select/invoke any of the entries). 3. Notice that the window size increases by approximately 5x5 characters. Happens on GNOME Shell on Wayland; does not happen on GNOME Shell or Unity 7 on X.Org. Ubuntu Artful, reproducible with their xfce4-terminal 0.8.6 package as well as current git. Discovered this while playing with https://bugzilla.gnome.org/show_bug.cgi?id=751064 https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1288655 https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1706008 Not sure if they are related. I have absolutely no clue what could be going on, and whether it's a bug in xfce4-terminal or elsewhere.
If I open the menu using the F10 key, the window size immediately increases at that point too (and once again later when I close the menu).
Igor referenced this bugreport in commit 71bc9086016062faa90485d27d4fe522609d44d7 Fix size increase when the menu is used on Wayland https://git.xfce.org/apps/xfce4-terminal/commit?id=71bc9086016062faa90485d27d4fe522609d44d7
Hi Egmont, (a little late) thanks for the report! I finally got to it. The terminal still can grow on multiple occasions (when gtk_window_resize() is involved) but that's a different issue.
Verified, thanks!
Egmont, have you been able to resolve the window resizing issues (e.g., when opening/closing a tab, etc.) in gnome-terminal?
Which issue do you mean exactly? We had/have several ones. The unfixed ones occurring to me are: - spurious back and forth resize events (https://bugzilla.gnome.org/show_bug.cgi?id=731137) which will require heavy changes (different strategy for fullscreen/maximized vs. normal windows), - fullscreen/maximize back and forth shrinking the window on Wayland (https://gitlab.gnome.org/GNOME/gnome-terminal/issues/129), probably a GTK issue.
xfce4-terminal window grows in size when opening (or closing) a second tab - i.e. when the tabbar gets shown or hidden. Have you had this issue with gnone-terminal?
Oh, I forgot to mention - that's on wayland.
Grows exactly as much as needed to accomodate for the tabbar (or its removal), so that the actual terminal area remains the same size? This has always been the intended behavior for gnome-terminal. Or do you mean a larger amount of growing? If you don't like this, you have two approaches. Either unconditionally show the tabbar (even with 1 tab), or give up on geometry hints and go with continuous resize (since it's pretty unlikely that both the same overall window size, both with and without the tabbar, results in an aligned VTE size).
Ohh, I see. xfce4-terminal indeed grows more than necessary on Wayland. I don't think gnome-terminal ever had this problem, and I'd guess the fix would be similar to the one you just submitted here.
I've fixed it! The problem was in an incorrect calculation of the new window size which somehow only caused the issue on Wayland and not on X.