! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Notifications penetrate xscreensaver
Status:
RESOLVED: MOVED
Product:
Xfce4-notifyd
Component:
general

Comments

Description haarp 2017-10-19 08:40:00 CEST
Notifications are visible while xscreensaver is locking and blanking the screen. This is a major security issue.

I propose having Do-not-disturb mode activate automatically as long as a screensaver is active.

e.g. via XScreenSaverQueryInfo(), which is part of X
Comment 1 Simon Steinbeiss editbugs 2017-10-22 14:35:19 CEST
I have tried and cannot reproduce this.

Also I'm not sure if you're not confusing two things:
 1) XScreensaver (https://www.jwz.org/xscreensaver/)
 2) the X11 screensaver extension (https://www.x.org/releases/X11R7.7/doc/scrnsaverproto/saver.html) which relates to XScreenSaverQueryInfo()

In any case, please clarify and provide more detailed instructions on how to reproduce. I tried with both 1) and 2) and the notification windows where never above the screensaver.
If it happens with 1) then it's a bug in XScreensaver - no window should ever be able to live above its lockscreen.
Comment 2 haarp 2017-10-22 14:56:44 CEST
I am referring to jwz's xscreensaver (5.36)

jwz himself covered this problem in an FAQ: https://www.jwz.org/xscreensaver/faq.html#popup-windows

Which points at this being a window manager bug. I am using Xfwm4 4.13.0, but without the compositor, if that matters.

However I did not have this problem with the GTK2 version of notifyd, so I am inclined to call this a notifyd bug.


Repro:

1. sleep 10; notify-send hello
2. Lock screen, move mouse so the password entry dialog appears
3. After a few seconds, a "hello" notification is visible
Comment 3 Simon Steinbeiss editbugs 2017-10-22 16:54:31 CEST
I'm running xfwm4 4.12.4, so maybe this is why I don't see this problem at all.

I think it's related to Gtk3 somehow, cause ever since the port the notification popups also overlay the menus of panel plugins (which was not the case with Gtk2). I have investigated this previously but found no related change in notifyd itself from gtk2 to gtk3, so I presume it must be a combination of Gtk3 and Xfwm4...

Anyhow, I'd rather not implement application specific code, so if it can be avoided to check for XScreensaver I'd rather resolve this differently.
Comment 4 haarp 2017-10-22 17:09:30 CEST
XScreenSaverQueryInfo() is not application specific, however, it's part of X11. And storing notifications (by enabling DnD mode will one is active) is probably a good idea either way.
Comment 5 haarp 2017-10-22 21:39:50 CEST
Additional information: This bug only happens when Xfwm's compositor is disabled.
Comment 6 Git Bot editbugs 2020-05-24 20:05:07 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-notifyd/-/issues/7.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #13936

Reported by:
haarp
Reported on: 2017-10-19
Last modified on: 2020-05-24

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

Additional information