Created attachment 7366
Wrong colors, several plugins affected
Plugin does not take correct color from theme, when the panel is pale-grey, plugin's background is dark-grey/black.
Affected several plugins:
date and time,
Should I create bugs for all affected plugins?
Bug looks the same.
I dont have that issue here, so i guess it depends on your theme... using greybird here, works fine.
(In reply to Landry Breuil from comment #2)
> I dont have that issue here, so i guess it depends on your theme... using
> greybird here, works fine.
The problem is: different panel plugins use different color ID for the same element. Looks like this. So, the problem is not in theme. May be Greybird has the same color for different IDs (for example, 'background selected' and 'backgrond highlated'). In xfce4-slate theme the problem persists. So, may be that'll be enough check bacground color ID in weather, tray or windows switcher plugin (correct colors) and check the same in four plugins in first post. I guess the IDs differ.
At least in mpc (which i wrote, i only sort of co-maintain datetime and netload) i do nothing specific to the background, there's no 'background color id' or css class applied to the background widget to my knowledge...
>At least in mpc (which i wrote, i only sort of co-maintain datetime and netload) i do nothing >specific to the background, there's no 'background color id' or css class applied to the >background widget to my knowledge...
CSS? What engine does the plugin use? GTK3 and not GTK2? xfce4 4.12 uses GTK2, at least in Fedora.
I stand corrected, be it with gtk2 or gtk3, in the mpc code, there's nothing specific being done about the styling (just look at the code), so the theme colors should just apply.... and mpc plugin uses gtk3 since 0.5.0. Ask the xfce4-slate theme developer ? But from what im seeing on your screenshot, that looks like a theme issue where it's only written for a version of gtk and doesnt support multiple versions - have you tried with other themes ?
Looks like mpc pluging (and all with problem) takes colors from gtk3 themes, and most of panel plugins uses gtk2 settings.
All themes affected.
Look at theese screenshots:
GTK2 theme is oxygen-gtk and GTK3 theme is Breeze.
Sylphhed, xfce4-panel and most of xfce4-panel plugins (tray, window switcher, window mwnu, clock, timer, weather, cpu monitor) use colors of GTK2 theme.
EasyStroke and some plugins (mpc, netmon, getmon) use colors of GTK3 theme.
Well, that's... expected. Unless you have a single unified theme that does both Gtk2 and Gtk3, you cant decide which plugin uses which theme, the Gtk3 plugins will use the Gtk3 theme and the Gtk2 plugins will use the Gtk2 theme. In your case i suppose your distro updated some plugins to their Gtk3 version.
Closing, theming issue imo, not plugin-specific..
-- GitLab Migration Automatic Message --
This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/panel-plugins/xfce4-mpc-plugin/-/issues/2.
Please create an account or use an existing account on one of our supported OAuth providers.
If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests
Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev