! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Embedding can break settings window behavior
Settings Manager


Description Viktor Odintsev editbugs 2017-09-08 23:43:30 CEST
There is a bug in xfce4-panel so it opens in new window instead of embedding.

But after unsuccessful embedding all other entries are opened in new window.

Steps to reproduce:

1. Install xfce4-settings 4.13.1 and xfce4-panel 4.13.1
2. Open settings manager and try to open panel settings: a new window will open (seems like panel bug, unrelated)
3. Close panel settings window
4. Try to open any other window (e. g. desktop settings)

Expected behavior: desktop settings window is embedded.
Actual behavior: a new desktop settings window is opened.
Comment 1 Viktor Odintsev editbugs 2017-09-13 01:18:42 CEST
Created attachment 7312 
Remove existing socket from socket viewport

So my approach is simple: just remove existing socket from container if user decides to open a new settings category. At least for user it will look as usual.
Comment 2 Viktor Odintsev editbugs 2017-09-13 23:44:22 CEST
Created attachment 7315 
Remove existing socket from socket viewport

I forgot to unref socket_item. Updating the patch.
Comment 3 Skunnyk editbugs 2017-10-01 15:29:19 CEST
I can reproduce the bug, and can confirm that the patch fix the issue.
Comment 4 Git Bot editbugs 2017-12-19 11:02:09 CET
Viktor Odintsev referenced this bugreport in commit 9161d49d3d010746ef44b14a11b4ded6117a826e

Remove existing socket from socket viewport (Bug #13847)

Comment 5 Sean Davis editbugs 2017-12-19 11:02:55 CET
Patch applied in above commit. Thanks!

Bug #13847

Reported by:
Viktor Odintsev
Reported on: 2017-09-08
Last modified on: 2017-12-19


Nick Schermer
CC List:
7 users




Additional information