! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Drag and drop from FUSE shares to other applications


Description Colin Leroy 2017-09-08 09:47:36 CEST
Created attachment 7307 
The patch


Currently, we can't drag and drop from a FUSE network share to an application that only handles native (file://) URIs.
This makes it impossible to, for example:
- attach a file from a Samba share in Claws Mail
- upload a file from a Samba share into a Chromium or Firefox upload box.

The attached patch tries to send native (file://) URIs instead of network URIs (smb://). 

Thanks for considering it :)

Comment 1 Skunnyk editbugs 2017-09-09 18:58:16 CEST
I can confirm that the patch works on a linux system with current thunar master. 
Tested with a file on a  smb:// share, I can drag a drop it to firefox, the url is correctly resolved to the "local" file:///run/user/[...] path. 
Maybe need some tests on other OS (!= linux).
Comment 2 Colin Leroy 2017-09-11 09:12:33 CEST
At worst, it should not work in the same way as currently on other OSes :)
Comment 3 Git Bot editbugs 2017-09-12 04:18:06 CEST
Colin Leroy referenced this bugreport in commit 5f1c0e8974a7680fa45b4cfbd1ba398d303eeb24

Prefer local (file://) URIs than native ones (e.g. smb://) (Bug #13845)

Comment 4 Git Bot editbugs 2017-09-12 04:21:55 CEST
Colin Leroy referenced this bugreport in commit 9c9e12038f2861124448510785fc9e51634da0f3

Prefer local (file://) URIs than native ones (e.g. smb://) (Bug #13845)

Comment 5 Andre Miranda editbugs 2017-09-12 04:23:00 CEST
I just pushed your patch to master and xfce-4.12 branches. Nice work, thanks!
Comment 6 Colin Leroy 2017-09-12 07:40:54 CEST
Thanks Andre :)

Bug #13845

Reported by:
Colin Leroy
Reported on: 2017-09-08
Last modified on: 2017-09-12


Xfce Bug Triage
CC List:
4 users




The patch (1.25 KB, patch)
2017-09-08 09:47 CEST , Colin Leroy
no flags

Additional information