! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Quicklaunch icons buttons disappear with xfconf 4.13
Status:
RESOLVED: FIXED
Priority:
Very High
Severity:
blocker
Product:
Xfdashboard
Component:
General

Comments

Description Olivier Duchateau 2017-08-25 19:43:54 CEST
Created attachment 7298 
Fix quicklaunch buttons with xfconf 4.13

With patch for garcon (bug #13785), quicklaunch buttons have disappeared (xfconf-query -c xfdashboard -p /favourites displays right list). As I use xfconf 4.13 dbus_g_type_get_collection function is obsolete, so I replaced by GType holding  GPtrArray, now everything works fine.

Patch for garcon is required for Gtk >= 3.22.18.

As Xfdashboard 0.7.x is devel release, that's why I updated its version in configure script.
Comment 1 Stephan Haller editbugs 2017-09-14 09:00:26 CEST
Thanks a lot. That's exactly what I was looking for when raising the xfconf version in the dependencies. But I saw at Github that you also have a patch to support both xfconf versions - 4.12 and 4.13. Could you provide this patch or theses patches here as I don't know how to remove a single commit from your pull request :(
Comment 2 Stephan Haller editbugs 2017-09-14 11:19:42 CEST
Created attachment 7317 
Fix quicklaunch buttons with xfconf 4.13 (but keep support for legacy version)

I just merged the two commits to support xfconf version 4.12.x (legacy) and xfconf 4.13.x into this one patch.

Could you please review it and check if it still works for you?
Comment 3 Olivier Duchateau 2017-09-14 19:24:37 CEST
Your patch works fine. Tested only with xfconf 4.13.x on FreeBSD and Fedora 26 (I use my own .spec files).
Comment 4 Git Bot editbugs 2017-09-15 11:01:29 CEST
Stephan Haller referenced this bugreport in commit 2bbd63888036782f5fb84519eb1f4d7f643391ed

Add compile-time checked support for xfconf version 4.12.x (called legacy here) and xfconf 4.13.x.

https://git.xfce.org/apps/xfdashboard/commit?id=2bbd63888036782f5fb84519eb1f4d7f643391ed
Comment 5 Stephan Haller editbugs 2017-09-15 11:02:05 CEST
Wohooo .... :) Great.

It's also in git now with commit 2bbd63888036782f5fb84519eb1f4d7f643391ed

Closing this bug report.

Bug #13824

Reported by:
Olivier Duchateau
Reported on: 2017-08-25
Last modified on: 2017-09-15

People

Assignee:
Stephan Haller
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information