After updating all core components to current master, session is hanging indefinitely on shutdown, restart, log out. I can't find any suspect error message on log, only: (xfce4-session:4300): Gtk-CRITICAL **: gtk_widget_set_visible: assertion 'GTK_IS_WIDGET (widget)' failed (xfce4-session:4300): GLib-GObject-WARNING **: invalid (NULL) pointer instance (xfce4-session:4300): GLib-GObject-CRITICAL **: g_signal_emit_valist: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed Sometimes I can't even switch to another TTY to kill xfce4-session, but I'm not sure this is related or another component is the culprit.
With the help of ninetls, we're able to find out that Thunar is the culprit, killing it makes session finish almost instantaneously. However, when I reverted to session 4.12, Thunar hangs for about 8 seconds and then the session is finished, so it leads me to think that we hit a regression, now session waits indefinitely for the processes to quit.
Created attachment 7290 xfsm-manager: pass manager variable to g_timeout_add g_timeout_add now takes manager_quit_signal instead gtk_main_quit. In this function XfsmManager instance is used to emit MANAGER_QUIT signal which was forgotten to be passed to g_timeout_add. This patch fixes this problem, now Xfsm should shutdown the session after 7 seconds as it was before.
Viktor Odintsev referenced this bugreport in commit b9cfbafe7cc9517dc424212aca0199f037eb977d xfsm-manager: pass manager variable to g_timeout_add (Bug #13802) https://git.xfce.org/xfce/xfce4-session/commit?id=b9cfbafe7cc9517dc424212aca0199f037eb977d
Thanks Viktor, I pushed it to master and gave you credit for your work!